Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v29.5.0 #80753

Merged
merged 5 commits into from
Oct 19, 2020
Merged

Upgrade EUI to v29.5.0 #80753

merged 5 commits into from
Oct 19, 2020

Conversation

chandlerprall
Copy link
Contributor

Upgrades EUI from 29.3 to 29.5. The overwhelming majority of snapshot changes (and the one unit test) are due to EUI's icon mock switching from a div to span elastic/eui#4099.

29.5.0

  • Added plus and minus glyphs to EuiIcon (#4111)

Bug fixes

  • Fixed custom color render of EuiIcon app (two-tone) icons (#4104)
  • Changed iconType prop to be required in EuiButtonIcon (#4106)

29.4.0

  • Added childrenBetween prop to EuiInMemoryTable to add content between search bar and table (#4103)
  • Added max-width: 100% to EuiKeyPadMenu to allow it to shrink when its container is smaller than its fixed width ( #4092)
  • Added key to EuiComboBoxOptionOption to allow duplicate labels (#4048)
  • Changed EuiIcon test mock to render as span instead of div (#4099)
  • Added scripts/docker-puppeteer as the new home for test-related Docker images (#4062)

Bug fixes

  • Fixed EuiFieldSearch padding when isClearable but has no value (#4089)

@chandlerprall chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 15, 2020
@chandlerprall chandlerprall requested review from a team as code owners October 15, 2020 20:58
@chandlerprall chandlerprall requested a review from a team October 15, 2020 20:58
@chandlerprall chandlerprall requested review from a team as code owners October 15, 2020 20:58
@chandlerprall chandlerprall requested a review from a team October 15, 2020 20:58
@chandlerprall chandlerprall requested a review from a team as a code owner October 15, 2020 20:58
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

cjcenizal
cjcenizal approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES UI snapshot changes LGTM.

kindsun
kindsun approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maps changes lgtm w/ green CI!

  • code review

lizozom
lizozom approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM snapshots changes

chrisronline
chrisronline approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack Monitoring changes LGTM!

flash1293
flash1293 reviewed Oct 16, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KibanaApp changes LGTM, those were only related to the div -> span change. Didn't test locally

jportner
jportner approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security/Spaces changes LGTM!

clintandrewhall
clintandrewhall approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2G for Canvas.

smith
smith approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes look good.

justinkambic
justinkambic approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM

patrykkopycinski
patrykkopycinski approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIEM/Endpoint changes LGTM!

jasonrhodes
jasonrhodes approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DIVs became SPANs OMG (LGTM)

@chandlerprall chandlerprall force-pushed the eui-29-5-0 branch 2 times, most recently from 3d8bd08 to 7465944 Compare October 19, 2020 17:14
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/ui-shared-deps asset size

id before after diff
css 645.2KB 645.3KB +89.0B
kbn-ui-shared-deps.@elastic.js 2.4MB 2.4MB +26.7KB
kbn-ui-shared-deps.js 4.7MB 4.7MB +480.0B
total +27.3KB

async chunks size

id before after diff
securitySolution 8.1MB 8.1MB +54.0B

distributable file count

id before after diff
default 48035 48042 +7
oss 28563 28570 +7

page load bundle size

id before after diff
spaces 364.4KB 364.4KB -1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chandlerprall chandlerprall merged commit 42a1744 into elastic:master Oct 19, 2020
@chandlerprall chandlerprall deleted the eui-29-5-0 branch October 19, 2020 20:49
@chandlerprall chandlerprall mentioned this pull request Oct 20, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 20, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/cloud-cal…
b281379 
…lout-for-warm-and-cold-tier

* 'master' of github.com:elastic/kibana: (126 commits)
  Add cumulative sum expression function (elastic#80129)
  [APM] Fix link to trace (elastic#80993)
  Provide url rewritten in onPreRouting interceptor (elastic#80810)
  limit renovate to npm packages
  Fix bug in logs UI link (elastic#80943)
  [Monitoring] Fix bug with setup mode appearing on pages it shouldn't (elastic#80343)
  [Security Solution][Detection Engine] Fixes false positives caused by empty records in threat list
  docs test (elastic#81080)
  Fixed alerts ui test timeout issue, related to the multiple server calls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (elastic#81067)
  [APM] Fix service map highlighted edge on node select (elastic#80791)
  Fix typo in toast, slight copy adjustment. (elastic#80843)
  [Security Solution] reduce optimizer limits (elastic#80997)
  [maps] 7.10 documentation updates (elastic#79917)
  [Workplace Search] Fix Group Prioritization route and clean up design (elastic#80903)
  [Enterprise Search] Added reusable HiddenText component to Credentials (elastic#80033)
  Upgrade EUI to v29.5.0 (elastic#80753)
  [Maps] Fix layer-flash when changing style (elastic#80948)
  [Security Solution] [Detections] Disable edit button when user does not have actions privileges w/ rule + actions (elastic#80220)
  [Enterprise Search] Handle loading state on Credentials page (elastic#80035)
  [Monitoring] Fix cluster listing page in how it handles global state (elastic#78979)
  ...
chandlerprall added a commit that referenced this pull request Oct 20, 2020
@chandlerprall
Upgrade EUI to v29.5.0 (#80753) (#81102)
b200fb9 
* Upgraded eui to v29.5.0; snapshot updates

* Cleaned up some types

* addresses feedback on types change

* Update EuiIcon snapshots in jest integration tests

* Updated snapshot from rebasing on master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 left review comments

@jportner jportner jportner approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@smith smith smith approved these changes

@lizozom lizozom lizozom approved these changes

@kindsun kindsun kindsun approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@clintandrewhall clintandrewhall clintandrewhall approved these changes

@jasonrhodes jasonrhodes jasonrhodes approved these changes

@chrisronline chrisronline chrisronline approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

@justinkambic justinkambic justinkambic approved these changes

@mshustov mshustov mshustov approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.