Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed alerts ui test timeout issue, related to the multiple server calls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. #81067

Conversation

YulNaumenko
Copy link
Contributor

Based on the team discussion, the best solution here should be to have a Bulk delete request instead of 10 deletes, but it will require a bunch of changes which is not expected to be a part of GA. This PR is a simple solution, which should cover the required test logic to verify if Delete All button works as expected.
When the Bulk delete will be implemented we can reintroduce the logic with the pagination and Delete All logic together.

One more time try to Resolve #77401

…lls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout.
@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 Project:Alerting labels Oct 19, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner October 19, 2020 21:06
@YulNaumenko YulNaumenko self-assigned this Oct 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@YulNaumenko YulNaumenko added the release_note:skip Skip the PR/issue when compiling release notes label Oct 19, 2020
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko
Copy link
Contributor Author

Since the CI is happy https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/910/ I will merge it to master.

@YulNaumenko YulNaumenko merged commit ea7c255 into elastic:master Oct 20, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Oct 20, 2020
…lls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (elastic#81067)
YulNaumenko added a commit that referenced this pull request Oct 20, 2020
…lls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (#81067) (#81094)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 20, 2020
…lout-for-warm-and-cold-tier

* 'master' of github.com:elastic/kibana: (126 commits)
  Add cumulative sum expression function (elastic#80129)
  [APM] Fix link to trace (elastic#80993)
  Provide url rewritten in onPreRouting interceptor (elastic#80810)
  limit renovate to npm packages
  Fix bug in logs UI link (elastic#80943)
  [Monitoring] Fix bug with setup mode appearing on pages it shouldn't (elastic#80343)
  [Security Solution][Detection Engine] Fixes false positives caused by empty records in threat list
  docs test (elastic#81080)
  Fixed alerts ui test timeout issue, related to the multiple server calls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (elastic#81067)
  [APM] Fix service map highlighted edge on node select (elastic#80791)
  Fix typo in toast, slight copy adjustment. (elastic#80843)
  [Security Solution] reduce optimizer limits (elastic#80997)
  [maps] 7.10 documentation updates (elastic#79917)
  [Workplace Search] Fix Group Prioritization route and clean up design (elastic#80903)
  [Enterprise Search] Added reusable HiddenText component to Credentials (elastic#80033)
  Upgrade EUI to v29.5.0 (elastic#80753)
  [Maps] Fix layer-flash when changing style (elastic#80948)
  [Security Solution] [Detections] Disable edit button when user does not have actions privileges w/ rule + actions (elastic#80220)
  [Enterprise Search] Handle loading state on Credentials page (elastic#80035)
  [Monitoring] Fix cluster listing page in how it handles global state (elastic#78979)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Project:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v8.0.0
Projects
None yet
5 participants