-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiIcon] Add plus and minus glyphs #4111
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/ |
Just a note that the change to all icon files is a result of upgrading |
Honestly, I know it goes against our typical glyph making rules, but the 1.5px stroke makes such a small icon so much easier to see. I even checked it on a non-retina screen, and yes, while it's not as "crisp" as the single pixel, it's still bolder and easier to see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @cchaos have final say on the new icons, but the other 400 files changed LGTM 😄
Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/ |
Jenkins, test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! 👍
Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4111/ |
Summary
Adds
plus
andminus
glyphs. This PR contains the option where the stroke width is 1px. I also explored the option of 1.5px stroke width as you'll see in the screenshots below (plus1_5
andminus1_5
).Fixes #1748
Checklist
- [ ] Props have proper autodocs- [ ] Checked Code Sandbox works for the any docs examples- [x] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes