-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline sass-extract-js plugin #1590
Inline sass-extract-js plugin #1590
Conversation
Remove camelcasing Preserve hex values over rgb where possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks like it's almost there. I left just two small comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@chandlerprall WDYT? |
This contains breaking changes due to the removal of camelCasing. In particular the following properties will have to be replaced:
|
cc @zumwalt, @daveyholler and @peteharverson. We'll clean this up once it goes into Kibana, but we're going to do a breaking change to replace the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a CL. Please mark it as a breaking change. Thanks for doing this. One less regret from the past destroyed from my conscious :)
Here is a diff (stored for one month) in case anyone needs a reference of what this changes in the dist. I did a build and looked through the diff to make sure it matched what we'd expect.
It seems this is used in two files |
Oh, was a bit too quick and missed the changelog item. Adding it via this PR. Sorry. #1594 |
This fixes the `small` font scale of the log viewer to correctly reference the EUI font size again. Before this fix, the `small` font scale was rendered larger than `medium`. Similarly, the tick labels of the log minimap were being rendered too large. Both resulted from a breaking change of the exported variable names in elastic/eui#1590. fixes #32759
…#33411) This fixes the `small` font scale of the log viewer to correctly reference the EUI font size again. Before this fix, the `small` font scale was rendered larger than `medium`. Similarly, the tick labels of the log minimap were being rendered too large. Both resulted from a breaking change of the exported variable names in elastic/eui#1590. fixes elastic#32759
Closes #1588
Diff of the light theme with the new variables: https://www.diffchecker.com/ocT4Z4lA