Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Create Rollup Index Pattern' button badge color error #32954

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Mar 12, 2019

Clicking on "Create Index Pattern" causes a fatal error on master when rollup indices are available. Doesn't seem to occur on 6.x. @chandlerprall @thompsongl I'm guessing the exported color variables changed at some point, but maybe something else happened to cause this. Any ideas?

image

image

@cjcenizal cjcenizal added bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.2.0 v7.0.1 labels Mar 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Mar 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@thompsongl
Copy link
Contributor

@cjcenizal I believe it's the change introduced in elastic/eui#1590 (part of the 9.0.0 release). Unless a color variable is rgba, it's exported as hex.

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@cjcenizal
Copy link
Contributor Author

Thanks @thompsongl. Looks like that change went into Kibana for 7.1.0 via #32009.

@cjcenizal cjcenizal added v8.0.0 and removed bug Fixes for quality problems that affect the customer experience v7.0.1 labels Mar 12, 2019
@cjcenizal cjcenizal merged commit d5a910c into elastic:master Mar 12, 2019
@cjcenizal cjcenizal deleted the bug/rollup-index-pattern-button branch March 12, 2019 15:56
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants