adds support to pass descriptionID to bind a button and a description…

[PhilippBaranovskiy]

Fix: #1735

Summary

I've added passing descriptionId argument, also updated example as well as `changelog CHANGELOG.md

[PhilippBaranovskiy]

@cchaos could you have a look at this? Please, let me know whether something could be better.

[cchaos]

I think this is a good, but possibly temporary solution, as there is more accessibility enhancements that can be made overall to this component. For that reason, I don't think it's necessary to use the callout so large in the documentation but allow the props docs to handle the description of the prop.

I'm also curious as to how we passed card accessibility on the EUI side but not in Kibana.

[cchaos]

You can make this more succinct like and a little more generalized (it doesn't only need to be added to a footer button) like:

Passed down to description's <p> for binding via aria-labelledby on the card's call to action.

[cchaos]

Oh and also be sure to update the EuiCard's TS definitions in the card/index.d.ts

[PhilippBaranovskiy]

@cchaos, I've got two questions:

1. I do need to pass that this card accessibility change to Kibana (see (Accessibility) "Add" buttons provide no context on Sample Data page. kibana#28381)
2. If it is supposed to be a temporary solution, then I have to decline that approach and perform something another, because I'm not sure whether it is a good idea to make any updates on Kibana relying on temporary implementations. Could you please clarify your thought on that?

[cchaos]

As I mentioned in the issue #1735, there is a whole host of other accessibility improvements we can make to the EuiCard. We just hadn't made it a priority since it originally passed the accessibility tests #614. Therefore, this could possibly change when we do the accessibility improvement. I'll agree that maybe doing this now as a shim might cause breaking changes down the line, but I also don't want to block your implementation.

It's still possible to use the span with id in your implementation to create this effect. And I can put EuiCard accessibility higher on our roadmap so we can it done sooner.

[PhilippBaranovskiy]

I'm closing this since @cchaos is going to update Card's accessibility by importing some ideas from the guidance, which in fact may cross out the proposed implementation.
This question is still under discussing.