Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Accessibility) "Add" buttons provide no context on Sample Data page. #28381

Closed
aphelionz opened this issue Jan 9, 2019 · 4 comments
Closed

(Accessibility) "Add" buttons provide no context on Sample Data page. #28381

aphelionz opened this issue Jan 9, 2019 · 4 comments
Assignees
@PhilippBaranovskiy
Labels
blocked EUI Feature:Add Data Add Data and sample data feature on Home Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG A

Comments

@aphelionz
Copy link
Contributor

Steps to reproduce (assumes ChromeVox or similar)

  1. Create and open a new space in Kibana or log into a fresh instance
  2. Tab to any "Add" button, for example "Add APM"

screenshot_20190109_120158

Actual Result

  1. Button text is read without any extra hinting or instructions

Expected Result

  1. Button should read the help text above the button i.e. "APM automatically collects in-depth performance metrics and errors from inside your applications."

Meta Issue #27739

Kibana Version: 6.5

Relevant WCAG Criteria: 3.3.2 Labels or Instructions
@aphelionz aphelionz mentioned this issue Jan 9, 2019
Closed
4 tasks
@rayafratkina rayafratkina added Feature:Add Data Add Data and sample data feature on Home WCAG A Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes added the EUI label Feb 26, 2019
@timroes
Copy link
Contributor

timroes commented Feb 26, 2019

This would first need to be enabled in EUI, that we're able to attach an id to that description inside the card, since we currently cannot reference that via aria-describedby.

@timroes timroes added the blocked label Mar 1, 2019
@PhilippBaranovskiy PhilippBaranovskiy mentioned this issue Mar 15, 2019
Closed
@PhilippBaranovskiy PhilippBaranovskiy self-assigned this Mar 15, 2019
@PhilippBaranovskiy
Copy link
Contributor

@timroes, I've created an issue on EUI repo and discussed this thing here: elastic/eui#1735
Would it be acceptable from your perspective to just wrap description with a <span id="..."> tag?
I wouldn't suggest that approach and would prefer to fix that thing in EUI.

@PhilippBaranovskiy PhilippBaranovskiy mentioned this issue Mar 22, 2019
Closed
@PhilippBaranovskiy PhilippBaranovskiy mentioned this issue Mar 25, 2019
Merged
PhilippBaranovskiy added a commit to PhilippBaranovskiy/kibana that referenced this issue Mar 26, 2019
@PhilippBaranovskiy
Add buttons provide no context on Sample Data page. elastic#28381
c4e0ab2
@cchaos cchaos added EUI and removed Feature:EUI labels Aug 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippBaranovskiy PhilippBaranovskiy

Labels
blocked EUI Feature:Add Data Add Data and sample data feature on Home Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG A
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@aphelionz @cchaos @timroes @PhilippBaranovskiy @elasticmachine @rayafratkina