-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paddingSize prop to EuiCard and display example to docs #3638
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the display
example. I agree, I don't think we need the padding
one and we can eventually rely on the Playground for that.
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
652dac6
to
714f9e3
Compare
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round of comments.
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Checked it locally by changing the default value of paddingSize
, all the configurations still work (albeit don't all look great), but nothing breaks.
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
Summary
This PR adds the
paddingSize
prop toEuiCard
and the example for thedisplay
prop to the docs.Screenshot of different
paddingSize
s (s, m and l)Notes:
I excluded the option for no padding from
paddingSize
because I think given the characteristics of the component, it wouldn't make sense to have cards with no padding whatsoever.I didn't add an example for
paddingSize
since I saw that we don't usually do that (except forEuiPanel
) but happy to add one if we think it's necessary.Fixes #3552
Checklist
- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes