Upgrade EUI to v27.2.0 #72993
Closed
Upgrade EUI to v27.2.0 #72993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
added
v8.0.0
release_note:skip
thompsongl
commented
Jul 27, 2020
| @@ -34,7 +34,7 @@ export default function ({ getService, getPageObjects }) { | |||
|
|
|||
| it('should fetch new options when string field is filtered', async () => { | |||
| const initialOptions = await comboBox.getOptionsList('listControlSelect0'); | |||
| expect(initialOptions.trim().split('\n').join()).to.equal('BD,BR,CN,ID,IN,JP,NG,PK,RU,US'); | |||
| expect(initialOptions.trim().split('\n').join()).to.equal('BD,BR,CN,ID,IN,JP,NG,PK,RU'); | |||
There was a problem hiding this comment.
Changed underlying list virtualization library. Some EuiComboBox and EuiFilter* lists will technically render one fewer item, although no real change occurs because the item was not visible initially without scrolling.
thompsongl
commented
Jul 27, 2020
| @@ -67,7 +67,7 @@ export default function ({ getService, getPageObjects }) { | |||
|
|
|||
| it('uses default index pattern on an empty dashboard', async () => { | |||
| await testSubjects.click('addFilter'); | |||
| await dashboardExpect.fieldSuggestions(['bytes']); | |||
| await dashboardExpect.fieldSuggestions(['agent']); | |||
There was a problem hiding this comment.
Changed underlying list virtualization library. Some EuiComboBox and EuiFilter* lists will technically render one fewer item, although no real change occurs because the item was not visible initially without scrolling.
thompsongl
commented
Jul 27, 2020
Comment on lines
+274
to
+283
| windowProps: { | ||
| onScroll: ({ scrollOffset }) => | ||
| handleOnScroll( | ||
| timelines.filter((t) => !hideUntitled || t.title !== '').length, | ||
| timelineCount, | ||
| scrollOffset | ||
| ), | ||
| outerRef: selectableListOuterRef, | ||
| innerRef: selectableListInnerRef, | ||
| }, |
There was a problem hiding this comment.
The underlying virtualization library changed and the onScroll API along with it. All the pieces were still available to perform handleOnScroll as expected, but it required a "roll your own" approach.
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-oss-agent / Firefox UI Functional Tests.test/functional/apps/visualize/input_control_vis/chained_controls·js.visualize app input controls chained controls "before all" hook for "should disable child control when parent control is not set"Standard OutStack TraceKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/snapshot_restore/__jest__/client_integration. on component mount form validation snapshot settings (step 2) should correctly indicate data streams with a badgeStandard OutStack TraceKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/uptime/public/components/overview/filter_group/__tests__.FilterPopover component expands on button clickStandard OutStack Traceand 2 more failures, only showing the first 3. Build metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
|
Closing this run at an upgrade. We discovered some dependencies that should be moved to devDependencies and have a fixed release upcoming. Will open a fresh PR with the new release version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
v26.3.1⏩v27.2.027.2.0analyzeEventglyph inEuiIcon(#3729)EuiComboBoxto allow the options list to open for single selection custom options (#3706)useEuiI18nhook for localization (#3749)Bug fixes
EuiComboBoxalways showing a scrollbar (#3744)react-focus-lockwithreact-focus-on(#3631)EuiSuperDatePickerrelated to invalid andnulldate formatting (#3750)findTestSubjectandtakeMountedSnapshot(#3763)EuiComboBoxnot allowing clicks on previously virtualized items when inside ofEuiFormRow(#3784)[Space]as a way to select options inEuiSelectable(#3784)windowPropsinEuiSelectable(#3787)27.1.0titleElementanddescriptionElementprops toEuiStat(#3693)securityAnalyticsAppapp icon (#3720)src/testand@types/enzymereferences fromeui.d.ts(#3715)index.d.tsfile tolib/testandes/test(#3715)descriptionFlexItemPropsandfieldFlexItemPropsprops toEuiDescribedFormGroup(#3717)EuiBasicTable's default action's name configuration to accept a function that returns a React node (#3739)27.0.0paddingSizeprop toEuiCard(#3638)isClearableandplaceholderoptions toEuiColorPicker(#3689)label,labelPropsandvalueTextprops toEuiProgress(#3661)Bug fixes
EuiResizableContainerpreventing nested containers (#3699)EuiResizableContainerpreventing resizing by arrow keys in some cases (#3699)EuiHorizontalStepsrendering overEuiHeader(#3707)EuiSuperSelectlost focus after a value selection (#3734)Breaking changes
EuiSelectable(#3169)react-virtualizedreplaced withreact-windowvirtualizedPropsonEuiSelectableOptionsListrenamed towindowPropsrootIdand addedmakeOptionId,listId, andsetActiveOptionIndextoEuiSelectableListlistIdtoEuiSelectableSearchoptionspassed intoEuiSelectablecannot have anidonChangeto be passed intoEuiSelectableSearch