-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds display prop to EuiTooltip for common display block needs #4148
Conversation
Made this in a pair session with @glitteringkatie! She's gonna finish it up and add tests for me! |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4148/ |
💚 CLA has been signed |
Added tests! 🙌 It doesn't seem like I did the right things when pushing as it shows 2 different Katie Hugheses wrote and committed and neither have my picture and I've already signed a contributor agreement 🤔 I might need some help making sure I have the right workflow for dealing with |
@snide don't forget to add Katie to |
hehe thanks @andreadelrio |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4148/ |
@glitteringkatie is added to that team, but I think the CLA portion is handled differently. My guess is that we'll need @chandlerprall's help there. |
Looks like that commit (8f15f3a) wasn't made with the email address associated with the @glitteringkatie github account:
Email address needs to be set globally via |
I see what went wrong--I did |
8f15f3a
to
70507ae
Compare
Preview documentation changes for this PR: https://eui.elastic.co/pr_4148/ |
I resolved the changelog conflicts this morning and there's already another one! Is it better practice to leave fixing the changelog conflicts until the PR is approved/close to being approved assuming all it is is one added line? |
It's up to you really. I think your read on it is pretty well aligned. Personally, like those red notification dots, hate seeing conflicts so I'm constantly hitting that "Resolve conflicts" button. Also, it's a quick way to get the branch rebased with master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Welcome Katie! 😆
Looks like we've also got dueling PR's going. First one to get an approval wins a lollipop 🍭
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Preview documentation changes for this PR: https://eui.elastic.co/pr_4148/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. Just saw a couple extra minor things.
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Preview documentation changes for this PR: https://eui.elastic.co/pr_4148/ |
Summary
Fixes #4086 . Adds a
display
prop toEuiToolTip
for the common need of making the anchors block level elements.Checklist