fix combo box auto scrolling on componentDidUpdate #4879
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4879/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4879/ |
There was a problem hiding this comment.
This breaks the ability to arrow through the options (tested in FF)
In the video first I arrow up/down the the combobox on this branch and then I switch to master and do it again. On this branch, once you arrow past the visible list, the box doesn't scroll. On master, arrowing past the visible list scrolls the box.
Kapture.2021-06-14.at.17.38.35.mp4
|
Instead of moving the logic, I think it would work as intended if we added another condition checking for props.activeOptionIndex !== prevProps.activeOptionIndex |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4879/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4879/ |
EuiComboBox auto scrolls to the selected item in componentDidUpdate. This makes the combo box unusable, as it auto-scrolls away from where users are looking any time there is an update. This issue is occurring in maps elastic/kibana#78420.
This PR resolves the problem by moving the call to this.listRef.scrollToItem from componentDidUpdate to within setListRef.