Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v34.5.1 #103297

Merged
merged 7 commits into from
Jun 28, 2021
Merged

Upgrade EUI to v34.5.1 #103297

merged 7 commits into from
Jun 28, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jun 24, 2021 •
edited
Loading

Summary

eui@34.3.0 ⏩ eui@34.5.1

  • Deprecated secondary in favor of success for color option prop in all relevant components (name change only)
  • Updated styles and new opt-in functionality for EuiRange and EuiDualRange

34.5.1

Bug fixes

  • Fixed bug in EuiColorStops where the outline was flashing when clicking or adding stops in Safari (#4900)
  • Fixed showIcons prop in EuiSelectableListItem (#4920)
  • Changed mobileBreakpoints prop to optional EuiSideNav (#4921)

34.5.0

  • Added success as color option to EuiBadge, EuiTextColor, EuiText, EuiStat, and EuiExpression (#4888)
  • Changed default color props from secondary to success where necessary (#4888)
  • Added display of number of selected options in EuiSearchBar filters when numActiveFilters exists (#4748)
  • Reverted z-index: 1 on EuiPageBody (#4892)
  • Added updateButtonProps to EuiSuperDatePicker to provide more control over the update/refresh button (#4895)
  • Updated EuiNotificationEvent to render an icon instead of a button if onRead is undefined (#4881)
  • Added DraggableProvidedDragHandleProps interface from 'react-beautiful-dnd' (#4903)
  • Added success and accent color options to EuiButton (#4874)
  • Added success color option to EuiLink (#4874)

Bug fixes

  • Fixed EuiRange container expansion due to negative margin value (#4815)
  • Fixed EuiRange ticks position to better align with thumbs (#4815)
  • Fixed EuiComboBox disabled pills and text contrast (#4901)
  • Fixed EuiDataGrid footer and header rows jumps in Firefox (#4869)
  • Fixed shaded colors of EuiButtonIcon (#4874)
  • Fixed pageHeader display in EuiPageTemplate when template is empty or default (#4905)
  • Fixed EuiPageHeader bottom padding when borderBottom = true (#4905)
  • Fixed incomplete height and width information in EuiResizeObserver (#4909)

Theme: Amsterdam

  • Updated styles for EuiRange (#4815
  • Fixed more unique focus states using outline (#4876)
  • Fixed border-radius value of EuiPanel (#4876)
  • Fixed disabled background color of EuiCard for better visibility on subdued backgrounds (#4876)

34.4.0

  • Added draggable highlight area to EuiDualRange (#4776)

Bug fixes

  • Fixed auto scrolling on update in EuiComboBox (#4879)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.14.0 labels Jun 24, 2021
@cchaos cchaos mentioned this pull request Jun 24, 2021
Closed
@thompsongl thompsongl changed the title Upgrade EUI to v34.5.0 Upgrade EUI to v34.5.1 Jun 24, 2021
@thompsongl thompsongl marked this pull request as ready for review June 24, 2021 18:37
@thompsongl thompsongl requested review from a team as code owners June 24, 2021 18:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@cchaos cchaos mentioned this pull request Jun 24, 2021
Closed
4 tasks
jen-huang
jen-huang approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@cchaos cchaos mentioned this pull request Jun 24, 2021
Merged
nreese
nreese approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jloleysens
jloleysens approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppServices changes LGTM, did not test locally.

@elizabetdev elizabetdev mentioned this pull request Jun 28, 2021
Merged
2 tasks
crob611
crob611 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation changes look good 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.2MB 1.2MB -16.0B
securitySolution 6.2MB 6.2MB +314.0B
visTypeTimeseries 997.8KB 998.8KB +1.0KB
total +1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-css 511.0KB 520.3KB +9.3KB
kbnUiSharedDeps-elastic 2.6MB 2.6MB +8.7KB
kbnUiSharedDeps-js 6.4MB 6.4MB -23.0B
total +17.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl merged commit bd32299 into elastic:master Jun 28, 2021
@thompsongl thompsongl mentioned this pull request Jun 28, 2021
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Jun 28, 2021
@thompsongl
Upgrade EUI to v34.5.1 (elastic#103297)
4acb1cd 
* eui to 34.5.0

* snapshot updates

* Fix some page layouts

* eui to 34.5.1

Co-authored-by: cchaos <caroline.horn@elastic.co>
thompsongl added a commit that referenced this pull request Jun 28, 2021
@thompsongl
Upgrade EUI to v34.5.1 (#103297) (#103509)
db2c8c3 
* eui to 34.5.0

* snapshot updates

* Fix some page layouts

* eui to 34.5.1

Co-authored-by: cchaos <caroline.horn@elastic.co>

Co-authored-by: cchaos <caroline.horn@elastic.co>
@nreese nreese mentioned this pull request Jun 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

@jen-huang jen-huang jen-huang approved these changes

@crob611 crob611 crob611 approved these changes

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thompsongl @elasticmachine @kibanamachine @nreese @crob611 @jen-huang @jloleysens