[EuiResizeObserver, EuiBottomBar] Account for padding and border #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
reviewed
Jun 22, 2021
| top, | ||
| bottom, | ||
| left, | ||
| right, |
There was a problem hiding this comment.
Is it possible to add border sizing? I noticed this with docked flyouts where we add a 2px border, that this border isn't taken into account.
There was a problem hiding this comment.
Oh hmm. I figured border would also be part of the top, left, etc. data.
I'll update to just use getBoundingClientRect() instead, which is (I think) how it used to work.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4909/ |
thompsongl
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4909/ |
cchaos
approved these changes
Jun 22, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4909/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4907, in which it was discovered that height and width from
clientRectdo not include padding or border (DOM box model).This removes reliance on
clientRectdata and usesgetBoundingClientRectinstead.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes