[home] Fix add sample data page layout
#102647
Conversation
pgayvallet
added
Team:Core
pgayvallet
changed the title
add sample data page layout
pgayvallet
added
the
release_note:skip
|
Pinging @elastic/kibana-core (Team:Core) |
| {this.renderTabContent()} | ||
| </EuiPageBody> | ||
| </EuiPage> | ||
| <KibanaPageTemplate restrictWidth={1200}> |
There was a problem hiding this comment.
Can you also move the page header implementation to the pageHeader prop here?
| <KibanaPageTemplate restrictWidth={1200}> | |
| <KibanaPageTemplate | |
| restrictWidth={1200} | |
| pageHeader={{ | |
| pageTitle: (<FormattedMessage />), | |
| rightSideItems: [headerLinks], | |
| }} | |
| > |
|
@cchaos performed the requested changes, and moved the tabs inside the header.
|
There was a problem hiding this comment.
👍 LGTM! I told @pgayvallet that I have to look into the display of the bottom border on the page header when templates are "empty". Most likely an EUI fix needed.
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
FWIW, who will be reviewing it, similar happens on "Logs" and "Upload file" tabs. |
Yea, all tabs of the page were impacted and are fixed by the current PR |
* Fix add sample data layout * remove useless change * use KibanaPageTemplate * use pageHeader for the header * move tabs inside header * tweaks * fix imports
* Fix add sample data layout * remove useless change * use KibanaPageTemplate * use pageHeader for the header * move tabs inside header * tweaks * fix imports
|
@pgayvallet The follow-up fix for the page header is in this EUI upgrade PR #103297 |
Summary
Fix #102260
Part of #98359
Before
Notifications dismissed:
After
(don't mind the zoom-out, used it to reproduce the gaps more easily)