New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiPagination & Co.] Convert to Emotion styling #6109

Merged

thompsongl merged 13 commits into elastic:main from thompsongl:css-in-js/euipagination

Aug 30, 2022

Contributor

thompsongl commented Aug 4, 2022 •

edited

Loading

Summary

EuiPagination
EuiPaginationButton
EuiPaginationButtonArrow

Checklist

Checked in both light and dark modes
Checked in mobile
Checked in Chrome, Safari, Edge, and Firefox
Props have proper autodocs and playground toggles
Checked Code Sandbox works for any docs examples
Added or updated jest and cypress tests
Checked for breaking changes and labeled appropriately
A changelog entry exists and is marked appropriately

thompsongl added 3 commits

August 4, 2022 13:54


          convert euipagination to emotion styling

2365fa1


          convert euipaginationbutton and euipaginationbuttonarrow to emotion s…

9ca485c

…tyling


          remove unused sass

cf3156a

thompsongl added the emotion label

CL

421dcaf

thompsongl mentioned this pull request

[Meta][CSS-in-JS] Component conversions #5685

Closed

49 tasks

kibanamachine commented Aug 4, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6109/

thompsongl added 3 commits

August 23, 2022 13:03


          Merge branch 'main' into css-in-js/euipagination

c8c299a


          update button styles

5f18239


          snapshots

c36c894

kibanamachine commented Aug 23, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6109/


          better generated class names

1275f51

kibanamachine commented Aug 23, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6109/

thompsongl added 2 commits

August 24, 2022 10:14


          Merge branch 'main' into css-in-js/euipagination

7c06cb7


          Merge branch 'main' into css-in-js/euipagination

99dcddb

kibanamachine commented Aug 24, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6109/

thompsongl marked this pull request as ready for review

August 24, 2022 18:44

cee-chen reviewed

View reviewed changes

src/components/pagination/pagination_button.tsx Show resolved Hide resolved

cee-chen reviewed

View reviewed changes

src/components/pagination/pagination.styles.ts Outdated Show resolved Hide resolved

cee-chen reviewed

View reviewed changes

src/components/pagination/pagination.tsx Outdated Show resolved Hide resolved

cee-chen reviewed

View reviewed changes

src/components/pagination/pagination.tsx Outdated Show resolved Hide resolved

cee-chen reviewed

View reviewed changes

src/components/pagination/_pagination_button.scss Show resolved Hide resolved

cee-chen reviewed

View reviewed changes

src/components/pagination/pagination_button.styles.ts Outdated Show resolved Hide resolved

thompsongl added 3 commits

August 29, 2022 12:45


          Merge branch 'main' into css-in-js/euipagination

82ff0be


          use classname

62247cc


          specificity

a696bc3

kibanamachine commented Aug 29, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6109/

Contributor Author

thompsongl commented Aug 30, 2022

jenkins test this

kibanamachine commented Aug 30, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_6109/

cee-chen approved these changes

View reviewed changes

Contributor

cee-chen left a comment

Changes LGTM

thompsongl merged commit d61e591 into elastic:main

breehall mentioned this pull request

Bumping EUI to version 67.1.8 elastic/kibana#141279

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels