Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPagination & Co.] Convert to Emotion styling #6109

Merged
merged 13 commits into from
Aug 30, 2022
Merged

[EuiPagination & Co.] Convert to Emotion styling #6109

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2365fa1
convert euipagination to emotion styling
thompsongl Aug 4, 2022
9ca485c
convert euipaginationbutton and euipaginationbuttonarrow to emotion s…
thompsongl Aug 4, 2022
cf3156a
remove unused sass
thompsongl Aug 4, 2022
421dcaf
CL
thompsongl Aug 4, 2022
c8c299a
Merge branch 'main' into css-in-js/euipagination
thompsongl Aug 23, 2022
5f18239
update button styles
thompsongl Aug 23, 2022
c36c894
snapshots
thompsongl Aug 23, 2022
1275f51
better generated class names
thompsongl Aug 23, 2022
7c06cb7
Merge branch 'main' into css-in-js/euipagination
thompsongl Aug 24, 2022
99dcddb
Merge branch 'main' into css-in-js/euipagination
thompsongl Aug 24, 2022
82ff0be
Merge branch 'main' into css-in-js/euipagination
thompsongl Aug 29, 2022
62247cc
use classname
thompsongl Aug 29, 2022
a696bc3
specificity
thompsongl Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
>
<nav
aria-label="Pagination for table: "
class="euiPagination"
class="euiPagination emotion-euiPagination-EuiPagination"
>
<span
aria-atomic="true"
Expand All @@ -160,7 +160,7 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
<a
aria-controls="__table_generated-id"
aria-label="Previous page"
class="euiButtonIcon euiButtonIcon--xSmall euiPaginationArrowButton css-dsw53p-empty-text-hoverStyles-EuiButtonIcon"
class="euiButtonIcon euiButtonIcon--xSmall euiPaginationArrowButton css-oedqdf-empty-text-hoverStyles-EuiButtonIcon-euiPaginationArrowButton"
data-test-subj="pagination-button-previous"
href="#__table_generated-id"
rel="noreferrer"
Expand All @@ -175,15 +175,16 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
</a>
<ul
aria-label="Pagination for table: "
class="euiPagination__list"
class="emotion-euiPagination__list"
data-test-subj="euiPagination__list"
>
<li
class="euiPagination__item"
>
<a
aria-controls="__table_generated-id"
aria-label="Page 1 of 2"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton css-wvaqcf-empty-text"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton css-1lezzfe-empty-text-euiPaginationButton"
data-test-subj="pagination-button-0"
href="#__table_generated-id"
rel="noreferrer"
Expand All @@ -206,7 +207,7 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
aria-controls="__table_generated-id"
aria-current="true"
aria-label="Page 2 of 2"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton euiPaginationButton-isActive css-1at5a38-empty-disabled"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton css-gsmou9-empty-disabled-euiPaginationButton-isActive"
data-test-subj="pagination-button-1"
disabled=""
type="button"
Expand All @@ -225,7 +226,7 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
</ul>
<button
aria-label="Next page"
class="euiButtonIcon euiButtonIcon--xSmall euiPaginationArrowButton css-1pivaxp-empty-disabled-hoverStyles-EuiButtonIcon"
class="euiButtonIcon euiButtonIcon--xSmall euiPaginationArrowButton css-1qa11t0-empty-disabled-hoverStyles-EuiButtonIcon-euiPaginationArrowButton"
data-test-subj="pagination-button-next"
disabled=""
type="button"
Expand Down
13 changes: 7 additions & 6 deletions src/components/datagrid/__snapshots__/data_grid.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ exports[`EuiDataGrid pagination renders 1`] = `
>
<nav
aria-label="Pagination for preceding grid: test grid"
class="euiPagination"
class="euiPagination emotion-euiPagination-EuiPagination"
>
<span
aria-atomic="true"
Expand All @@ -54,7 +54,7 @@ exports[`EuiDataGrid pagination renders 1`] = `
<a
aria-controls="generated-id"
aria-label="Previous page"
class="euiButtonIcon euiButtonIcon--xSmall euiPaginationArrowButton css-dsw53p-empty-text-hoverStyles-EuiButtonIcon"
class="euiButtonIcon euiButtonIcon--xSmall euiPaginationArrowButton css-oedqdf-empty-text-hoverStyles-EuiButtonIcon-euiPaginationArrowButton"
data-test-subj="pagination-button-previous"
href="#generated-id"
rel="noreferrer"
Expand All @@ -69,15 +69,16 @@ exports[`EuiDataGrid pagination renders 1`] = `
</a>
<ul
aria-label="Pagination for preceding grid: test grid"
class="euiPagination__list"
class="emotion-euiPagination__list"
data-test-subj="euiPagination__list"
>
<li
class="euiPagination__item"
>
<a
aria-controls="generated-id"
aria-label="Page 1 of 2"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton css-wvaqcf-empty-text"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton css-1lezzfe-empty-text-euiPaginationButton"
data-test-subj="pagination-button-0"
href="#generated-id"
rel="noreferrer"
Expand All @@ -100,7 +101,7 @@ exports[`EuiDataGrid pagination renders 1`] = `
aria-controls="generated-id"
aria-current="true"
aria-label="Page 2 of 2"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton euiPaginationButton-isActive css-1at5a38-empty-disabled"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton css-gsmou9-empty-disabled-euiPaginationButton-isActive"
data-test-subj="pagination-button-1"
disabled=""
type="button"
Expand All @@ -119,7 +120,7 @@ exports[`EuiDataGrid pagination renders 1`] = `
</ul>
<button
aria-label="Next page"
class="euiButtonIcon euiButtonIcon--xSmall euiPaginationArrowButton css-1pivaxp-empty-disabled-hoverStyles-EuiButtonIcon"
class="euiButtonIcon euiButtonIcon--xSmall euiPaginationArrowButton css-1qa11t0-empty-disabled-hoverStyles-EuiButtonIcon-euiPaginationArrowButton"
data-test-subj="pagination-button-next"
disabled=""
type="button"
Expand Down
1 change: 0 additions & 1 deletion src/components/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
@import 'modal/index';
@import 'notification/index';
@import 'overlay_mask/index';
@import 'pagination/index';
@import 'panel/index';
@import 'page/index'; // Page needs to come after Panel for cascade specificity
@import 'tree_view/index';
Expand Down
Loading