Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Upgrading Cypress to version 12. #6990

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

1Copenut
Copy link
Contributor

@1Copenut 1Copenut commented Jul 25, 2023

Summary

Bumping Cypress to version 12.17.0 (current release)

Changed one test's invoke() method to resolve a promise using then() per the Cypress changelog:

The .invoke() command now throws an error if the invoked function returns a promise. If you wish to call a method that returns a promise and wait for it to resolve, use .then() instead of .invoke(). Addressed in #24417

QA

Ran Cypress tests locally:

  • yarn test-cypress
  • yarn test-cypress-a11y
  • Tested a handful of previous failing tests in the Cypress browser runner
  • Verified running Cypress 12 on Buildkite (via logs)

Screen Shot 2023-07-26 at 1 11 02 PM

@1Copenut 1Copenut added testing Issues or PRs that only affect tests - will not need changelog entries skip-changelog labels Jul 25, 2023
@1Copenut 1Copenut requested a review from cee-chen July 25, 2023 17:18
@1Copenut 1Copenut self-assigned this Jul 25, 2023
@cee-chen
Copy link
Member

cee-chen commented Jul 25, 2023

Nice work on this Trevor!

@tkajtoch do you have any preference to merging this in before or after the React 18 feature branch? I'm not sure if this will cause any issues for the existing package.json changes / Cypress setup work in that feature branch.

@1Copenut
Copy link
Contributor Author

buildkite test this

@tkajtoch
Copy link
Member

@cee-chen I'll test this against feature/react-18 shortly and see if there's any risk merging it now

@1Copenut
Copy link
Contributor Author

Thanks @cee-chen && @tkajtoch! I'm tweaking the Buildkite runtime commands a touch to make sure it runs at the right times for pull requests against any branch, and for forked repo requests. I'll wait to get a thumbs up here and merge that work before merging this one.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6990/

1 similar comment
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6990/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6990_buildkite/

@1Copenut 1Copenut requested a review from tkajtoch July 26, 2023 18:42
* Bumping Cypress to version 12.17.0.
* Changing invoke to then to resolve promise and not throw an error.
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran yarn test-cypress 3 times locally, passed each time.

FYI yarn test-cypress-a11y is now failing on main due to the React 18 changes, but I think that can/should be resolved separately from this PR. Follow up issue: #7024

@cee-chen cee-chen enabled auto-merge (squash) August 1, 2023 18:40
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6990/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6990_buildkite/

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @1Copenut

@cee-chen cee-chen merged commit ac996fa into elastic:main Aug 1, 2023
1 check passed
@1Copenut 1Copenut deleted the chore/upgrade-cypress-12 branch August 1, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog testing Issues or PRs that only affect tests - will not need changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE] Update Cypress to current v12
5 participants