[INFRA] Updating forked repo logic to build on every branch #6991
Conversation
1Copenut
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6991/ |
| @@ -8,5 +8,5 @@ steps: | |||
| build: | |||
| env: | |||
| GIT_BRANCH: "${BUILDKITE_BRANCH}" | |||
| GIT_PULL_REQUEST_ID: "${GITHUB_PR_NUMBER}" | |||
| GIT_PULL_REQUEST_ID: "${BUILDKITE_PULL_REQUEST}" | |||
There was a problem hiding this comment.
The move away from the feature branch target caused Buildkite to disregard GH-specific env variables. Dunno. But I did find this Buildkite default for branches, so updated both instances where I need it to create the comment link.
| @@ -10,8 +10,7 @@ | |||
| "trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | |||
| "always_trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | |||
| "set_commit_status": true, | |||
| "skip_ci_on_only_changed": ["^.github/", "^generator-eui/", "^wiki/"], | |||
| "target_branch": "feature/buildkite-migration" | |||
There was a problem hiding this comment.
Removing this line to allow Buildkite (with Elastic org approval still) to kick off jobs against any branch. Kibana does not have this line in the pull-request.json file either. Feel it's right to remove it here.
There was a problem hiding this comment.
Just curious, why was this not caught in #6965?
There was a problem hiding this comment.
That branch was built on the upstream EUI repo, not a fork. I didn't notice it until I made the forked PR this morning to update Cypress.
Wrong branch I was looking at. I didn't put two and two together that #6965 was ignoring Buildkite because of this config change needed. I didn't notice it until I made the forked PR this morning to update Cypress, then talked through the solution with one of the platform engineers.
There was a problem hiding this comment.
Gotcha - I'm more asking about the process used in #6965 that caused this instance to be missed. I would have assumed that searching/grepping for all instances of feature/buildkite-migration and either changing them to main or removing the logic completely would have been the approach to take. If it wasn't, I'd be curious why not / what other approach was used that caused this last reference to be missed.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6991/ |
1Copenut
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6991_buildkite/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6991/ |
| env: | ||
| GIT_BRANCH: "${BUILDKITE_BRANCH}" | ||
| GIT_PULL_REQUEST_ID: "${BUILDKITE_PULL_REQUEST}" | ||
| BUILDKITE_CI: "${BUILDKITE}" |
There was a problem hiding this comment.
I got a Buildkite error saying the step "build" had no type. Read through the docs on passing env variables into command steps and updated the syntax correctly.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6991_buildkite/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6991/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6991_buildkite/ |
Summary
Testing for Buildkite run against defaultmainbranch. Do not merge.Updating the
pull-request.jsonto removetarget_branchdeclaration. This should enable the bot to start pull requests for any forked repo, against any branch on EUI, safely.QA
Test will be verified by Buildkite UI.