-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Updating forked repo logic to build on every branch #6991
Changes from all commits
88d59ed
f94661a
9513161
92bc2bc
4f9fad3
55f5abe
b850f46
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,7 @@ steps: | |
- agents: | ||
provider: "gcp" | ||
command: .buildkite/scripts/pipeline_deploy_docs.sh | ||
- build: | ||
env: | ||
GIT_BRANCH: "${BUILDKITE_BRANCH}" | ||
GIT_PULL_REQUEST_ID: "${GITHUB_PR_NUMBER}" | ||
BUILDKITE_CI: "${BUILDKITE}" | ||
env: | ||
GIT_BRANCH: "${BUILDKITE_BRANCH}" | ||
GIT_PULL_REQUEST_ID: "${BUILDKITE_PULL_REQUEST}" | ||
BUILDKITE_CI: "${BUILDKITE}" | ||
Comment on lines
+7
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I got a Buildkite error saying the step "build" had no type. Read through the docs on passing env variables into |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,8 +10,7 @@ | |
"trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | ||
"always_trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | ||
"set_commit_status": true, | ||
"skip_ci_on_only_changed": ["^.github/", "^generator-eui/", "^wiki/"], | ||
"target_branch": "feature/buildkite-migration" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing this line to allow Buildkite (with Elastic org approval still) to kick off jobs against any branch. Kibana does not have this line in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just curious, why was this not caught in #6965? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Wrong branch I was looking at. I didn't put two and two together that #6965 was ignoring Buildkite because of this config change needed. I didn't notice it until I made the forked PR this morning to update Cypress, then talked through the solution with one of the platform engineers. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gotcha - I'm more asking about the process used in #6965 that caused this instance to be missed. I would have assumed that searching/grepping for all instances of |
||
"skip_ci_on_only_changed": ["^.github/", "^generator-eui/", "^wiki/"] | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The move away from the feature branch target caused Buildkite to disregard GH-specific env variables. Dunno. But I did find this Buildkite default for branches, so updated both instances where I need it to create the comment link.