fix: renderHook imports
#7697
Merged
fix: renderHook imports
#7697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and adjust tests to account for it
…/react` to make use of the dynamic react versioning
…r erroring out in watch mode when running on React <18
tkajtoch
commented
Apr 17, 2024
| @@ -6,9 +6,9 @@ | |||
| * Side Public License, v 1. | |||
| */ | |||
|
|
|||
| import { renderHook } from '@testing-library/react/pure'; // Pure is important here to preserve state between tests | |||
There was a problem hiding this comment.
This was the only place where we used @testing-library/react/pure, and I couldn't add it to src/test/rtl/render_hook since importing it overrides jest configuration globally (🤯), so I updated tests below to work with the regular (non-pure) renderHook.
|
Preview staging links for this PR:
|
💚 Build Succeeded
cc @tkajtoch |
mgadewoll
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merging in the #7646 work somehow triggered a chain of events that resulted in our
renderHookusage in jest tests to fail when running on React <18. TherenderHookhas to be imported conditionally from@testing-library/reactfor React 18 or@testing-library/react-hookfor React 16 and 17, which is done insrc/test/rtl/render_hook.ts.I'm not 100% sure why the tests importing
renderHookdirectly from@testing-library/reactweren't failing on React 16 and 17 for the past 6+ months, but the important thing is that this PR fixes all of these LOLQA
Ensure CI is passing and unit tests are passing on all React versions.