Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages/microsoft_sqlserver: Update documentation #10915

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

Linu-Elias
Copy link
Contributor

@Linu-Elias Linu-Elias commented Aug 28, 2024

Proposed commit message

This update to the MSSQL integration documentation includes information indicating that, by default, the system-level database transaction_log metrics for SQL Server instances are collected. Metrics for user-level databases can be collected either by specifying a list of user databases or, alternatively, by enabling the Fetch from all databases toggle to collect metrics from all databases on the server.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@Linu-Elias Linu-Elias requested a review from a team as a code owner August 28, 2024 13:24
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Aug 28, 2024
@gpop63
Copy link
Contributor

gpop63 commented Aug 28, 2024

/test

@shmsr shmsr changed the title Update MSSQL Documentation packages/microsoft_sqlserver: Update documentation Aug 28, 2024
Linu-Elias and others added 3 commits August 29, 2024 10:42
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
@Linu-Elias
Copy link
Contributor Author

/test

2 similar comments
@muthu-mps
Copy link
Contributor

/test

@Linu-Elias
Copy link
Contributor Author

/test

@shmsr
Copy link
Member

shmsr commented Aug 30, 2024

Hi @Linu-Elias. Can you see the buildkite logs or do you not have access? It is failing because of #10889 which I fixed in #10899

When the fix is merged to main, then you'd be able to merge this PR.

@Linu-Elias
Copy link
Contributor Author

Hi @Linu-Elias. Can you see the buildkite logs or do you not have access? It is failing because of #10889 which I fixed in #10899

When the fix is merged to main, then you'd be able to merge this PR.

yes @shmsr, I do have access and identified that the build is failing with error stating container status: unhealthy, I am waiting for the above PR to be merged. Thanks

@Linu-Elias
Copy link
Contributor Author

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @Linu-Elias

@muthu-mps muthu-mps merged commit 89a7c82 into elastic:main Aug 30, 2024
5 checks passed
@elasticmachine
Copy link

Package microsoft_sqlserver - 2.9.2 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants