packages/microsoft_sqlserver: Fix HEALTHCHECK

[shmsr]

Proposed commit message

Update the bin directory for sqlcmd because for 2019-latest the directory has changed and also how it works. Please see this comment and this comment for more details. As this is a change that affects only development, no CHANGELOG entry is needed.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

Related issues

• Closes [microsoft_sqlserver] Failing test daily: system test: errorlog in microsoft_sqlserver.log #10889

[elasticmachine]

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

[shmsr]

Also, see: #10889 (comment)

As tests were constantly failing had to debug it as well and track down the issue to:

ODBC driver version 18, is designed with an ‘encryption-first’ approach, ensuring that utilities like sqlcmd and bcp that utilize the Microsoft ODBC driver will operate under the ‘secure by default’ principle. Users who wish to disable encryption will need to do so explicitly.

So, the fix is to add "-No". Also, improved the HEALTHCHECK a bit.

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 51a4c41

History

• 💔 Build #15100 failed 3e72e1e
• 💚 Build #15096 succeeded 84b0780
• 💔 Build #15095 failed f1d984d8200eddbe714348bfc29a0b740241649d
• 💔 Build #15091 failed e5ec69ea318c948132a0ffb920885612e0601f0e

cc @shmsr

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[agithomas]

LGTM!