Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apache: refactor integration (part II) #441

Merged
merged 6 commits into from
Dec 8, 2020
Merged

Apache: refactor integration (part II) #441

merged 6 commits into from
Dec 8, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Dec 3, 2020 •
edited
Loading

What does this PR do?

This PR refactors the Apache integration according to action items defined in #370 .

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Author's Checklist

  • Update dashboards with latest changes in Metricbeat
  • Adjust field defintions after changes in Metricbeat
  • Update the sample event for status data stream
  • Save sample events for other data streams
  • Write pipeline tests for Apache

How to test this PR locally

CI tests will verify the ingest pipeline. Service metrics data should visible on dashboards.

Related issues

Screenshots

@mtojek mtojek self-assigned this Dec 3, 2020
@mtojek mtojek mentioned this pull request Dec 3, 2020
Closed
16 tasks
@elasticmachine
Copy link

elasticmachine commented Dec 3, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2020-12-07T22:28:22.680+0000

  • Duration: 18 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 72
Skipped 0
Total 72

@mtojek
Copy link
Contributor Author

mtojek commented Dec 3, 2020

Now I have to wait now until changes in Metricbeat are propagated to the Elastic Agent docker image and these tests will start passing.

@mtojek
Copy link
Contributor Author

mtojek commented Dec 4, 2020

jenkins run the tests please

2 similar comments
@mtojek
Copy link
Contributor Author

mtojek commented Dec 4, 2020

jenkins run the tests please

@mtojek
Copy link
Contributor Author

mtojek commented Dec 4, 2020

jenkins run the tests please

@exekias
Copy link

exekias commented Dec 4, 2020

Nice to see this moving forward! It would be good to update fields.yml to include unit and metric_type, WDYT?

@mtojek
Copy link
Contributor Author

mtojek commented Dec 4, 2020 •
edited
Loading

Nice to see this moving forward! It would be good to update fields.yml to include unit and metric_type, WDYT?

Let me try to update these. Is there any one-pager with available units/metric_types?

EDIT:

Found it: https://www.elastic.co/guide/en/elasticsearch/reference/master/mapping-field-meta.html

@mtojek mtojek force-pushed the 370-refactor-apache-part-ii branch from 0fdd089 to b5bf648 Compare December 4, 2020 11:41
@mtojek
Copy link
Contributor Author

mtojek commented Dec 4, 2020

jenkins run the tests please

@mtojek
Copy link
Contributor Author

mtojek commented Dec 4, 2020 •
edited
Loading

I need to wait a bit longer with this draft. The last builtin Metricbeat's commit in the Elastic Agent is b8a4a20a37daea7e78763da4e6f07238080cdfba.

@mtojek
Copy link
Contributor Author

mtojek commented Dec 7, 2020

jenkins run the tests please

@mtojek mtojek marked this pull request as ready for review December 7, 2020 08:37
@elasticmachine
Copy link

Pinging @elastic/integrations-services (Team:Services)

@mtojek mtojek requested review from a team and ycombinator December 7, 2020 08:37
ycombinator
ycombinator approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek mtojek merged commit e26e27a into elastic:master Dec 8, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@mtojek
Apache: refactor integration (part II) (elastic#441)
0d04cea 
* Adjust fields after changes in Metricbeat

* Adjust hostname

* Write sample events

* Add pipeline tests for access

* Write pipeline tests

* Define units and metric types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mtojek @elasticmachine @exekias @ycombinator @andresrc