Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recategorize integrations #5123

Merged
merged 24 commits into from
Mar 16, 2023
Merged

Recategorize integrations #5123

merged 24 commits into from
Mar 16, 2023

Conversation

jen-huang
Copy link
Contributor

@jen-huang jen-huang commented Jan 27, 2023 •
edited by jlind23
Loading

What does this PR do?

This PR adjusts integration categories based on the work done in https://github.com/elastic/ingest-dev/issues/1349 to streamline the UX for browsing integrations and introduces subcategories for particularly overloaded top-level categories.

All updated integrations have their patch version bumped.

Reviewers: Thank you for taking the time to review. I know this is a big PR! I recommend:

  1. You filter to files that you own
  2. If there is disagreement about any of the categories, please discuss offline and get consensus from the product owner (@mukeshelastic can help) before requesting a change

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.

Related PRs

Related issues

@elasticmachine
Copy link

elasticmachine commented Jan 27, 2023 •
edited
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-15T14:22:21.452+0000

  • Duration: 97 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 3848
Skipped 5
Total 3853

Steps errors 3

Expand to view the steps failures

Test integration: nats
  • Took 1 min 56 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Test integration: stan
  • Took 2 min 46 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jan 27, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (302/302) 💚
Files 97.363% (480/493) 👎 -2.637
Classes 97.363% (480/493) 👎 -2.637
Methods 91.727% (4967/5415) 👎 -8.273
Lines 92.42% (107876/116724) 👍 2.199
Conditionals 100.0% (0/0) 💚

@jen-huang jen-huang self-assigned this Jan 27, 2023
@jen-huang jen-huang added the enhancement New feature or request label Jan 27, 2023
@jsoriano
Copy link
Member

@jen-huang this can be rebased, missing categories should be available now after #5144.

@jen-huang jen-huang changed the title [WIP] Recategorize integrations Recategorize integrations Jan 30, 2023
@jen-huang jen-huang marked this pull request as ready for review January 30, 2023 21:29
@jen-huang jen-huang requested review from a team as code owners January 30, 2023 21:29
@jen-huang jen-huang requested review from belimawr, faec and gizas January 30, 2023 21:29
@elasticmachine
Copy link

Package udp - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=udp

@elasticmachine
Copy link

Package vsphere - 1.3.2 containing this change is available at https://epr.elastic.co/search?package=vsphere

@elasticmachine
Copy link

Package websphere_application_server - 0.3.1 containing this change is available at https://epr.elastic.co/search?package=websphere_application_server

@elasticmachine
Copy link

Package winlog - 1.12.3 containing this change is available at https://epr.elastic.co/search?package=winlog

@elasticmachine
Copy link

Package zeek - 2.7.1 containing this change is available at https://epr.elastic.co/search?package=zeek

@elasticmachine
Copy link

Package zerofox - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=zerofox

@elasticmachine
Copy link

Package zookeeper - 1.5.1 containing this change is available at https://epr.elastic.co/search?package=zookeeper

@elasticmachine
Copy link

Package zoom - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=zoom

@elasticmachine
Copy link

Package zscaler_zpa - 1.5.2 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@jen-huang @agithomas
Recategorize integrations (elastic#5123)
d519706 
* Recategorize integrations

* Fix typo, update PR link

* Update integrations thru 'C'

* Update integrations thru 'F'

* Update integrations thru 'K'

* Update integrations thru 'P'

* Update integrations thru 'Z'

* Classify vulnerability management integrations

* Fix typos

* Revert "Classify vulnerability management integrations"

This reverts commit 4cd834c.

* Missed commit

* bump up missed versions from conflict merge

* CR review

* Fix CI

* Fix merge

* Replace infrastructure with observability per CR

* Fix typos

* Add missed integration
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@jen-huang @agithomas
Recategorize integrations (elastic#5123)
541147f 
* Recategorize integrations

* Fix typo, update PR link

* Update integrations thru 'C'

* Update integrations thru 'F'

* Update integrations thru 'K'

* Update integrations thru 'P'

* Update integrations thru 'Z'

* Classify vulnerability management integrations

* Fix typos

* Revert "Classify vulnerability management integrations"

This reverts commit 4cd834c.

* Missed commit

* bump up missed versions from conflict merge

* CR review

* Fix CI

* Fix merge

* Replace infrastructure with observability per CR

* Fix typos

* Add missed integration
jen-huang added a commit to elastic/endpoint-package that referenced this pull request Mar 21, 2023
@jen-huang
Update Endpoint package categories (#354)
6a43c3d 
* Update categories

Update integration category per decision in elastic/ingest-dev#1349.

Related to elastic/integrations#5123.

* Update categories in .bumpversion.cfg
@elasticmachine
Copy link

Package google_workspace - 2.4.0 containing this change is available at https://epr.elastic.co/search?package=google_workspace

@jen-huang jen-huang mentioned this pull request Mar 23, 2023
Merged
jen-huang added a commit to elastic/kibana that referenced this pull request Mar 29, 2023
@jen-huang @kibanamachine
[Fleet] Sync integration categories and update tutorials and custom i…
4fbc834 
…ntegrations (#153216)

## Summary

Part of elastic/integrations#5123. This PR:

1) Syncs hardcoded list of integration categories against the latest
list from [package
spec](https://github.com/elastic/package-registry/blob/24557251ec27b4eb2caf715169301bbe15e01c21/categories/categories.yml)
2) Brings the categories used by the "home tutorial" cards and custom
integrations cards in line with the above PR

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
jen-huang added a commit to elastic/kibana that referenced this pull request Mar 29, 2023
@jen-huang
[Fleet] Enable showing integration subcategories (#153591)
88b9f1a 
## Summary

Now that elastic/integrations#5123 and #153216
is complete, this PR enables the integration subcategories feature by
default. Users will see a much shorter list of top-level integration
categories when they land in Browse Integrations. Once the user clicks
into a category, subcategories will be presented if there are any (see
#148894 for more details).

With the associated changes now merged and enabling this flag, the list
now looks like this initially:


![image](https://user-images.githubusercontent.com/1965714/227375323-bd649342-1deb-4106-aaa5-0e7573574d2d.png)

And when clicking into a large category with subcategories:


![image](https://user-images.githubusercontent.com/1965714/227375436-7203aec0-48ee-4861-8a5d-af9ce37dedad.png)
jgowdyelastic pushed a commit to jgowdyelastic/kibana that referenced this pull request Mar 30, 2023
@jen-huang @jgowdyelastic
[Fleet] Enable showing integration subcategories (elastic#153591)
fafa627 
## Summary

Now that elastic/integrations#5123 and elastic#153216
is complete, this PR enables the integration subcategories feature by
default. Users will see a much shorter list of top-level integration
categories when they land in Browse Integrations. Once the user clicks
into a category, subcategories will be presented if there are any (see
elastic#148894 for more details).

With the associated changes now merged and enabling this flag, the list
now looks like this initially:


![image](https://user-images.githubusercontent.com/1965714/227375323-bd649342-1deb-4106-aaa5-0e7573574d2d.png)

And when clicking into a large category with subcategories:


![image](https://user-images.githubusercontent.com/1965714/227375436-7203aec0-48ee-4861-8a5d-af9ce37dedad.png)
@susan-shu-c susan-shu-c mentioned this pull request Apr 12, 2023
Closed
8 tasks
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 18, 2023
Closed
@elasticmachine
Copy link

Package cloud_security_posture - 1.3.0-preview4 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.3.0-preview5 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.3.0-preview6 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.3.0-preview7 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.3.0-preview8 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.3.0-preview9 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.3.0-preview10 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.3.0-preview91 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehynds jamiehynds jamiehynds left review comments

@tinnytintin10 tinnytintin10 tinnytintin10 left review comments

@endorama endorama endorama left review comments

@jsoriano jsoriano jsoriano left review comments

@CohenIdo CohenIdo CohenIdo approved these changes

@oren-zohar oren-zohar oren-zohar approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@gizas gizas Awaiting requested review from gizas gizas is a code owner automatically assigned from elastic/obs-cloudnative-monitoring

@MichaelKatsoulis MichaelKatsoulis Awaiting requested review from MichaelKatsoulis MichaelKatsoulis is a code owner automatically assigned from elastic/obs-cloudnative-monitoring

Assignees

@jen-huang jen-huang

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jen-huang @elasticmachine @jsoriano @SubhrataK @endorama @alvarezmelissa87 @tinnytintin10 @jamiehynds @oren-zohar @CohenIdo