Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Enable showing integration subcategories #153591

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

jen-huang
Copy link
Contributor

@jen-huang jen-huang commented Mar 23, 2023

Summary

Now that elastic/integrations#5123 and #153216 is complete, this PR enables the integration subcategories feature by default. Users will see a much shorter list of top-level integration categories when they land in Browse Integrations. Once the user clicks into a category, subcategories will be presented if there are any (see #148894 for more details).

With the associated changes now merged and enabling this flag, the list now looks like this initially:

image

And when clicking into a large category with subcategories:

image

@jen-huang jen-huang added release_note:enhancement backport:skip This commit does not require backporting labels Mar 23, 2023
@jen-huang jen-huang requested a review from criamico March 23, 2023 19:01
@jen-huang jen-huang self-assigned this Mar 23, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 23, 2023
@jen-huang jen-huang marked this pull request as ready for review March 29, 2023 15:51
@jen-huang jen-huang requested a review from a team as a code owner March 29, 2023 15:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@jen-huang jen-huang merged commit 88b9f1a into elastic:main Mar 29, 2023
@jen-huang jen-huang deleted the fix/enable-subcategories branch March 29, 2023 17:51
jgowdyelastic pushed a commit to jgowdyelastic/kibana that referenced this pull request Mar 30, 2023
## Summary

Now that elastic/integrations#5123 and elastic#153216
is complete, this PR enables the integration subcategories feature by
default. Users will see a much shorter list of top-level integration
categories when they land in Browse Integrations. Once the user clicks
into a category, subcategories will be presented if there are any (see
elastic#148894 for more details).

With the associated changes now merged and enabling this flag, the list
now looks like this initially:


![image](https://user-images.githubusercontent.com/1965714/227375323-bd649342-1deb-4106-aaa5-0e7573574d2d.png)

And when clicking into a large category with subcategories:


![image](https://user-images.githubusercontent.com/1965714/227375436-7203aec0-48ee-4861-8a5d-af9ce37dedad.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants