Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][MongoDB] Add custom number formatting to visualizations #8334

Conversation

rajvi-patel-22
Copy link
Contributor

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

Revisit panels and add custom number formatting (2000->2k) to visualizations.
[Reference]
image

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.10.2 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 self-assigned this Oct 30, 2023
@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review October 30, 2023 12:55
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner October 30, 2023 12:55
@elasticmachine
Copy link

elasticmachine commented Oct 30, 2023

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-30T13:26:31.682+0000

  • Duration: 23 min 24 sec

Test stats 🧪

Test Results
Failed 4
Passed 20
Skipped 0
Total 24

Test errors 4

Expand to view the tests failures

system test: collstats – mongodb.collstats
    Expand to view the error details

     null 
    

    Expand to view the stacktrace

     one or more errors found in documents stored in metrics-mongodb.collstats-ep data stream: [0] found error.message in event: ['top' command failed: server selection error: server selection timeout, current topology: { Type: Unknown, Servers: [{ Addr: elastic-package-service-mongodb-1:27017, Type: RSGhost, Average RTT: 723023 }, ] }] 
    

system test: dbstats – mongodb.dbstats
    Expand to view the error details

     null 
    

    Expand to view the stacktrace

     one or more errors found in documents stored in metrics-mongodb.dbstats-ep data stream: [0] found error.message in event: [could not retrieve database names from Mongo instance: server selection error: server selection timeout, current topology: { Type: Unknown, Servers: [{ Addr: elastic-package-service-mongodb-1:27017, Type: RSGhost, Average RTT: 548908 }, ] }] 
    

system test: metrics – mongodb.metrics
    Expand to view the error details

     null 
    

    Expand to view the stacktrace

     one or more errors found in documents stored in metrics-mongodb.metrics-ep data stream: [0] found error.message in event: [failed to retrieve data from 'serverStatus' command: server selection error: server selection timeout, current topology: { Type: Unknown, Servers: [{ Addr: elastic-package-service-mongodb-1:27017, Type: RSGhost, Average RTT: 729808 }, ] }] 
    

system test: status – mongodb.status
    Expand to view the error details

     null 
    

    Expand to view the stacktrace

     one or more errors found in documents stored in metrics-mongodb.status-ep data stream: [0] found error.message in event: [failed to retrieve 'serverStatus': server selection error: server selection timeout, current topology: { Type: Unknown, Servers: [{ Addr: elastic-package-service-mongodb-1:27017, Type: RSGhost, Average RTT: 564354 }, ] }] 
    

Steps errors 2

Expand to view the steps failures

Test integration: mongodb
  • Took 7 min 20 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 96.97% (32/33)
Lines 68.217% (88/129)
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22
Copy link
Contributor Author

/test

@rajvi-patel-22 rajvi-patel-22 marked this pull request as draft November 1, 2023 06:51
@botelastic
Copy link

botelastic bot commented Dec 1, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Dec 1, 2023
@ali786XI
Copy link
Contributor

ali786XI commented Dec 4, 2023

/test

@botelastic botelastic bot removed the Stalled label Dec 4, 2023
@mrodm
Copy link
Contributor

mrodm commented Dec 21, 2023

Hi @rajvi-patel-22, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

@botelastic
Copy link

botelastic bot commented Jan 20, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 20, 2024
@botelastic
Copy link

botelastic bot commented Feb 19, 2024

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][MongoDB] Add custom number formatting to visualizations
4 participants