Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][MongoDB] Migrate Metrics Overview dashboard visualizations to lens in kibana 8.1.0 #5830

Merged

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Apr 10, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for MongoDB integration package

  • Statistics for MongoDB Lens migration:

MongoDB dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics MongoDB] Overview 0 8 8 0
  0 8 8 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.1.0 itself.

Related issues

Issues Identified

Note: The Kibana files and screenshot of dashboard are not synced. Please find below image to compare before and after migration visualizations.
screencapture-storage-0-kb-us-central1-gcp-cloud-es-io-9243-app-dashboards-2023-03-15-12_04_37 (1)

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner April 10, 2023 13:34
@kush-elastic kush-elastic added enhancement New feature or request Integration:mongodb MongoDB v8.1.0 Team:Service-Integrations Label for the Service Integrations team labels Apr 10, 2023
@elasticmachine
Copy link

elasticmachine commented Apr 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-10T13:38:29.892+0000

  • Duration: 18 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 96.97% (32/33) 👎 -3.03
Lines 68.217% (88/129) 👎 -20.913
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the panels, can we change the number formatting to have more human readable style?

image

Please verify for other panels as well

@rajvi-patel-22
Copy link
Contributor Author

For the panels, can we change the number formatting to have more human readable style?

@agithomas, we can not provide the number formatting in lens. There is an open issue for the same elastic/kibana#72711.

@agithomas
Copy link
Contributor

@agithomas, we can not provide the number formatting in lens. There is an open issue for the same elastic/kibana#72711.

Can you please bring this issue to the Issues Identified section in the meta issue? To me, it is an important one to track.

cc @lalit-satapathy

@agithomas
Copy link
Contributor

Please complete the peer review.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit 5b39ce6 into elastic:main Apr 11, 2023
@elasticmachine
Copy link

Package mongodb - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=mongodb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:mongodb MongoDB Team:Service-Integrations Label for the Service Integrations team v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants