-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O11y][Oracle] Add custom number formatting to visualisations #8381
[O11y][Oracle] Add custom number formatting to visualisations #8381
Conversation
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parse time value (bar chart) is showing negative values. Similarly others as well. Please revisit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sysmetric dashboard is not consistant in terms of usage of theme colors. Please align the color themes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ratio of used space dashboard is not showing any value. Please revist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please align the Lock/Pin dashboard of Oracle Overview dashboard seems to be not aligned with the colors. Please revisit
Please refer to the previous conversation for the same. This is applicable to all the visualizations that are using differences currently.
Updated. |
Checked the formula and it is as expected. I have updated the screenshot by populating the data so it shows different values and sorts them properly. Updated the visualization in Overview and Tablespace dashboard as it is present at both places. Also one more thing I noticed, as per this comment, the visualization was not showing values when it reaches the top limit of 10 values. Hence, increased the size of visualization as well to accumulate the values. Added the same
For this visualization, please refer to the documentation here. I don’t find it as a percentage field. Also while looking at the Ratio of used space in data file visualization Tablespace dashboard, I found that the Rank By is not set to use proper fields, hence updated that as well. Please have a look at the settings before and after. |
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package oracle - 1.23.0 containing this change is available at https://epr.elastic.co/search?package=oracle |
Description
Workaround implemented during lens migration
Used default format and migrated visualization to the lens.
Checklist
changelog.yml
file.Updated number formatting for the following dashboards
Related issues
Note
According to this comment received for MongoDB, we also checked for the panels in Oracle that require custom number formatting. However, it had an open issue which was released in the 8.10 version of Kibana. Hence updated the Kibana version to 8.10.2 for the change to be available in Kibana.