Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Oracle] Add custom number formatting to visualisations #8381

Merged

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Nov 2, 2023

Description

Workaround implemented during lens migration

Used default format and migrated visualization to the lens.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Updated number formatting for the following dashboards

  • [Metrics Oracle] Performance Metrics
  • [Metrics Oracle] System Statistics Metrics
  • [Metrics Oracle] Sysmetric Metrics
  • [Metrics Oracle] Tablespace
  • [Metrics Oracle] Overview

Related issues

Note

According to this comment received for MongoDB, we also checked for the panels in Oracle that require custom number formatting. However, it had an open issue which was released in the 8.10 version of Kibana. Hence updated the Kibana version to 8.10.2 for the change to be available in Kibana.

@kush-elastic kush-elastic self-assigned this Nov 2, 2023
@kush-elastic kush-elastic added enhancement New feature or request Integration:oracle Oracle dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Nov 2, 2023
@kush-elastic kush-elastic marked this pull request as ready for review November 2, 2023 10:18
@kush-elastic kush-elastic requested a review from a team as a code owner November 2, 2023 10:18
@elasticmachine
Copy link

elasticmachine commented Nov 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-01T11:56:36.515+0000

  • Duration: 307 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 2, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (29/29) 💚 2.469
Lines 94.424% (254/269) 👍 11.896
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parse time value (bar chart) is showing negative values. Similarly others as well. Please revisit

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sysmetric dashboard is not consistant in terms of usage of theme colors. Please align the color themes

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ratio of used space dashboard is not showing any value. Please revist

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align the Lock/Pin dashboard of Oracle Overview dashboard seems to be not aligned with the colors. Please revisit

@kush-elastic
Copy link
Collaborator Author

Parse time value (bar chart) is showing negative values. Similarly others as well. Please revisit

Please refer to the previous conversation for the same. This is applicable to all the visualizations that are using differences currently.

Sysmetric dashboard is not consistant in terms of usage of theme colors. Please align the color themes
Ratio of used space dashboard is not showing any value. Please revist
Please align the Lock/Pin dashboard of Oracle Overview dashboard seems to be not aligned with the colors. Please revisit

Updated.

@agithomas
Copy link
Contributor

Requesting for a revalidation. Please refer to the panel below. All the values are exactly the same to the 1/1000th place. Requesting for a re-check if the viz formula are indeed correct. Please confirm

image

@agithomas
Copy link
Contributor

agithomas commented Nov 24, 2023

For other panels when Y axis value is percentage, % is added in the Y-axis values. Please add it here to ensure consistency.

image

@agithomas
Copy link
Contributor

Please refer here . Is the Y-axis value '%' ? if Yes, please add that .

image

@kush-elastic
Copy link
Collaborator Author

Requesting for a revalidation. Please refer to the panel below. All the values are exactly the same to the 1/1000th place. Requesting for a re-check if the viz formula are indeed correct. Please confirm

Checked the formula and it is as expected. I have updated the screenshot by populating the data so it shows different values and sorts them properly. Updated the visualization in Overview and Tablespace dashboard as it is present at both places. Also one more thing I noticed, as per this comment, the visualization was not showing values when it reaches the top limit of 10 values. Hence, increased the size of visualization as well to accumulate the values.

For other panels when Y axis value is percentage, % is added in the Y-axis values. Please add it here to ensure consistency.

Added the same

Please refer here . Is the Y-axis value '%' ? if Yes, please add that.

For this visualization, please refer to the documentation here. I don’t find it as a percentage field.

Also while looking at the Ratio of used space in data file visualization Tablespace dashboard, I found that the Rank By is not set to use proper fields, hence updated that as well. Please have a look at the settings before and after.

Before:-
image

After:-
image

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ali786XI ali786XI merged commit 2b9c9ec into elastic:main Dec 5, 2023
4 checks passed
@elasticmachine
Copy link

Package oracle - 1.23.0 containing this change is available at https://epr.elastic.co/search?package=oracle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:oracle Oracle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][Oracle] Add custom number formatting to visualizations
5 participants