Skip to content

Commit

Permalink
Revert "fixes the provider name flexibility" (#107649) (#107692)
Browse files Browse the repository at this point in the history
The heuristic to select provider name `cloud-basic` breaks the CCS
integration tests, where protocol is https, and actually is not needed in
any of the automated tests.

For a better solution we need @MadameSheema to be back from PTO.

This partially reverts commit 9f2d9d4.

Co-authored-by: Domenico Andreoli <domenico.andreoli@elastic.co>
  • Loading branch information
kibanamachine and cavokz authored Aug 4, 2021
1 parent 520f798 commit 89ce789
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions x-pack/plugins/security_solution/cypress/tasks/login.ts
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,6 @@ const credentialsProvidedByEnvironment = (): boolean =>
* Kibana's `/internal/security/login` endpoint, bypassing the login page (for speed).
*/
const loginViaEnvironmentCredentials = () => {
const providerName =
Cypress.env('protocol') === 'http' || Cypress.config().baseUrl!.includes('staging')
? 'basic'
: 'cloud-basic';

cy.log(
`Authenticating via environment credentials from the \`CYPRESS_${ELASTICSEARCH_USERNAME}\` and \`CYPRESS_${ELASTICSEARCH_PASSWORD}\` environment variables`
);
Expand All @@ -218,7 +213,7 @@ const loginViaEnvironmentCredentials = () => {
cy.request({
body: {
providerType: 'basic',
providerName,
providerName: 'basic',
currentURL: '/',
params: {
username: Cypress.env(ELASTICSEARCH_USERNAME),
Expand Down

0 comments on commit 89ce789

Please sign in to comment.