Revert "fixes the provider name flexibility"

[cavokz]

The heuristic to select provider name cloud-basic breaks the CCS
integration tests, where protocol is https, and actually is not needed in
any of the automated tests.

For a better solution we need @MadameSheema to be back from PTO.

This partially reverts commit 9f2d9d4.

[marius-dr]

I am fine with the revert and a rethinking of it with Gloria when she comes back, but I was also thinking maybe you could also add to the condition for the ternary, something like this:

 const providerName =
    Cypress.env('protocol') === 'http' || Cypress.config().baseUrl!.includes('staging') || Cypress.env('VM') === 'ubuntu16_tar_ccs_cypress'
      ? 'basic'
      : 'cloud-basic';

I put the check for the VM env variable, but if you ever want to add another one we can think of another ENV variable that we can look for or even create a new one.

[cavokz]

I put the check for the VM env variable, but if you ever want to add another one we can think of another ENV variable that we can look for or even create a new one.

I understand that checking for VM env would also work but it would be a hack, right? The cleanest solution I can imagine is adding a KIBANA_PROVIDERNAME variable, defaulting to basic when it's not defined.

I just wanted to check with Glo before inventing anything new. And I don't feel it's right continuously adding env variables, the most global among the globals.. :)

[marius-dr]

Waiting for Glo sounds good. For now LGTM.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 9a0a3d2
• Storybooks Preview

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.14
✅	7.x

The backport PRs will be merged automatically after passing CI.