Skip to content

Commit

Permalink
[Alerts] Add spaces as optional dep to triggers_actions_ui (#93267) (#…
Browse files Browse the repository at this point in the history
…93305)

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/plugin.ts
  • Loading branch information
Zacqary authored Mar 2, 2021
1 parent a09a8ad commit 9fd352b
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion x-pack/plugins/triggers_actions_ui/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "kibana",
"server": true,
"ui": true,
"optionalPlugins": ["alerts", "features", "home"],
"optionalPlugins": ["alerts", "features", "home", "spaces"],
"requiredPlugins": ["management", "charts", "data", "kibanaReact", "kibanaUtils", "savedObjects"],
"configPath": ["xpack", "trigger_actions_ui"],
"extraPublicDirs": ["public/common", "public/common/constants"],
Expand Down
3 changes: 3 additions & 0 deletions x-pack/plugins/triggers_actions_ui/public/application/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import { ActionTypeRegistryContract, AlertTypeRegistryContract } from '../types'
import { ChartsPluginStart } from '../../../../../src/plugins/charts/public';
import { DataPublicPluginStart } from '../../../../../src/plugins/data/public';
import { PluginStartContract as AlertingStart } from '../../../alerts/public';
import type { SpacesPluginStart } from '../../../spaces/public';

import { suspendedComponentWithProps } from './lib/suspended_component_with_props';
import { Storage } from '../../../../../src/plugins/kibana_utils/public';
import { EuiThemeProvider } from '../../../../../src/plugins/kibana_react/common';
Expand All @@ -33,6 +35,7 @@ export interface TriggersAndActionsUiServices extends CoreStart {
data: DataPublicPluginStart;
charts: ChartsPluginStart;
alerts?: AlertingStart;
spaces?: SpacesPluginStart;
storage?: Storage;
setBreadcrumbs: (crumbs: ChromeBreadcrumb[]) => void;
actionTypeRegistry: ActionTypeRegistryContract;
Expand Down
4 changes: 4 additions & 0 deletions x-pack/plugins/triggers_actions_ui/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ import { DataPublicPluginStart } from '../../../../src/plugins/data/public';
import { Storage } from '../../../../src/plugins/kibana_utils/public';
import type { ConnectorAddFlyoutProps } from './application/sections/action_connector_form/connector_add_flyout';
import type { ConnectorEditFlyoutProps } from './application/sections/action_connector_form/connector_edit_flyout';
import type { SpacesPluginStart } from '../../spaces/public';

import { getAddConnectorFlyoutLazy } from './common/get_add_connector_flyout';
import { getEditConnectorFlyoutLazy } from './common/get_edit_connector_flyout';
import { getAddAlertFlyoutLazy } from './common/get_add_alert_flyout';
Expand Down Expand Up @@ -66,6 +68,7 @@ interface PluginsStart {
data: DataPublicPluginStart;
charts: ChartsPluginStart;
alerts?: AlertingStart;
spaces?: SpacesPluginStart;
navigateToApp: CoreStart['application']['navigateToApp'];
features: FeaturesPluginStart;
}
Expand Down Expand Up @@ -140,6 +143,7 @@ export class Plugin
data: pluginsStart.data,
charts: pluginsStart.charts,
alerts: pluginsStart.alerts,
spaces: pluginsStart.spaces,
element: params.element,
storage: new Storage(window.localStorage),
setBreadcrumbs: params.setBreadcrumbs,
Expand Down

0 comments on commit 9fd352b

Please sign in to comment.