Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerts] Add spaces as optional dep to triggers_actions_ui #93267

Merged
merged 1 commit into from
Mar 2, 2021
Merged

[Alerts] Add spaces as optional dep to triggers_actions_ui #93267

merged 1 commit into from
Mar 2, 2021

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Mar 2, 2021

Summary

Enables #92661 to pass

Adds the spaces plugin as an optional dependency for triggers_actions_ui, making spaces services available in the plugin's Kibana context.

This is necessary for Infrastructure Anomaly alerts to be usable in the Alert Management UI.

@Zacqary Zacqary added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 NeededFor:logs-metrics-ui v7.13.0 labels Mar 2, 2021
@Zacqary Zacqary requested a review from a team as a code owner March 2, 2021 17:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.2KB +109.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

YulNaumenko
YulNaumenko approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary Zacqary merged commit 6be9ada into elastic:master Mar 2, 2021
@Zacqary Zacqary deleted the triggersactions-add-spaces branch March 2, 2021 20:08
Zacqary added a commit to Zacqary/kibana that referenced this pull request Mar 2, 2021
@Zacqary
[Alerts] Add spaces as optional dep to triggers_actions_ui (elastic#9…
8994d3a 
…3267)
This was referenced Mar 2, 2021
Merged
Merged
Zacqary added a commit to Zacqary/kibana that referenced this pull request Mar 2, 2021
@Zacqary
[Alerts] Add spaces as optional dep to triggers_actions_ui (elastic#9…
9864e78 
…3267)

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/plugin.ts
Zacqary added a commit that referenced this pull request Mar 2, 2021
@Zacqary
[Alerts] Add spaces as optional dep to triggers_actions_ui (#93267) (#…
9fd352b 
…93305)

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/plugin.ts
Zacqary added a commit that referenced this pull request Mar 2, 2021
@Zacqary
[Alerts] Add spaces as optional dep to triggers_actions_ui (#93267) (#…
0be2f15 
…93304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees
No one assigned
Labels
Feature:Alerting NeededFor:logs-metrics-ui release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zacqary @elasticmachine @kibanamachine @YulNaumenko