Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerts] Add spaces as optional dep to triggers_actions_ui #93267

Merged
merged 1 commit into from
Mar 2, 2021
+7 −1
Merged

[Alerts] Add spaces as optional dep to triggers_actions_ui #93267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/triggers_actions_ui/kibana.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "kibana",
"server": true,
"ui": true,
"optionalPlugins": ["alerts", "features", "home"],
"optionalPlugins": ["alerts", "features", "home", "spaces"],
"requiredPlugins": ["management", "charts", "data", "kibanaReact", "kibanaUtils", "savedObjects"],
"configPath": ["xpack", "trigger_actions_ui"],
"extraPublicDirs": ["public/common", "public/common/constants"],
Expand Down
3 changes: 3 additions & 0 deletions x-pack/plugins/triggers_actions_ui/public/application/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import { ActionTypeRegistryContract, AlertTypeRegistryContract } from '../types'
import { ChartsPluginStart } from '../../../../../src/plugins/charts/public';
import { DataPublicPluginStart } from '../../../../../src/plugins/data/public';
import { PluginStartContract as AlertingStart } from '../../../alerts/public';
import type { SpacesPluginStart } from '../../../spaces/public';

import { suspendedComponentWithProps } from './lib/suspended_component_with_props';
import { Storage } from '../../../../../src/plugins/kibana_utils/public';
import { EuiThemeProvider } from '../../../../../src/plugins/kibana_react/common';
Expand All @@ -33,6 +35,7 @@ export interface TriggersAndActionsUiServices extends CoreStart {
data: DataPublicPluginStart;
charts: ChartsPluginStart;
alerts?: AlertingStart;
spaces?: SpacesPluginStart;
storage?: Storage;
setBreadcrumbs: (crumbs: ChromeBreadcrumb[]) => void;
actionTypeRegistry: ActionTypeRegistryContract;
Expand Down
3 changes: 3 additions & 0 deletions x-pack/plugins/triggers_actions_ui/public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import { ChartsPluginStart } from '../../../../src/plugins/charts/public';
import { PluginStartContract as AlertingStart } from '../../alerts/public';
import { DataPublicPluginStart } from '../../../../src/plugins/data/public';
import { Storage } from '../../../../src/plugins/kibana_utils/public';
import type { SpacesPluginStart } from '../../spaces/public';

import { getAddConnectorFlyoutLazy } from './common/get_add_connector_flyout';
import { getEditConnectorFlyoutLazy } from './common/get_edit_connector_flyout';
Expand Down Expand Up @@ -68,6 +69,7 @@ interface PluginsStart {
data: DataPublicPluginStart;
charts: ChartsPluginStart;
alerts?: AlertingStart;
spaces?: SpacesPluginStart;
navigateToApp: CoreStart['application']['navigateToApp'];
features: FeaturesPluginStart;
}
Expand Down Expand Up @@ -142,6 +144,7 @@ export class Plugin
data: pluginsStart.data,
charts: pluginsStart.charts,
alerts: pluginsStart.alerts,
spaces: pluginsStart.spaces,
element: params.element,
storage: new Storage(window.localStorage),
setBreadcrumbs: params.setBreadcrumbs,
Expand Down