[Logs UI] Fix column reordering in settings page (#58104) (#58150)

elastic · Feb 21, 2020 · f3137a2 · f3137a2
1 parent eafda0f
commit f3137a2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/x-pack/plugins/infra/public/apps/start_app.tsx b/x-pack/plugins/infra/public/apps/start_app.tsx
@@ -79,6 +79,7 @@ export async function startApp(
   // expected.
   element.style.height = '100%';
   element.style.display = 'flex';
+  element.style.overflowY = 'hidden'; // Prevent having scroll within a container having scroll. It messes up with drag-n-drop elements
   element.className += ` ${CONTAINER_CLASSNAME}`;
 
   ReactDOM.render(<App />, element);

diff --git a/...ins/infra/public/components/source_configuration/log_columns_configuration_form_state.tsx b/...ins/infra/public/components/source_configuration/log_columns_configuration_form_state.tsx
@@ -108,7 +108,7 @@ export const useLogColumnsConfigurationFormState = ({
 
   const moveLogColumn = useCallback(
     (sourceIndex, destinationIndex) => {
-      if (destinationIndex >= 0 && sourceIndex < formState.logColumns.length - 1) {
+      if (destinationIndex >= 0 && sourceIndex <= formState.logColumns.length - 1) {
         const newLogColumns = [...formState.logColumns];
         newLogColumns.splice(destinationIndex, 0, newLogColumns.splice(sourceIndex, 1)[0]);
         setFormStateChanges(changes => ({