Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Logs UI] Fix column reordering in settings page (#58104) #58150

Merged
merged 2 commits into from
Feb 21, 2020

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Feb 20, 2020

Backports the following commits to 7.x:

* Ensure only one element has scroll

Apparently having multiple elements with scroll confuses the
`react-beautiful-dnd` mechanism to determine the position of the
elements. Adding `overflowY` to the app root fixes it.

* Fix upper bound check for log column reordering

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@afgomez
Copy link
Contributor Author

afgomez commented Feb 21, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-oss-agent / Example plugin functional tests.test/examples/embeddables/adding_children·ts.embeddable explorer creating and adding children Can create a new child

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:43]         └-: embeddable explorer
[00:00:43]           └-> "before all" hook
[00:00:43]           └-> "before all" hook
[00:00:43]             │ debg navigating to settings url: http://localhost:6111/app/kibana#/management
[00:00:43]             │ debg Navigate to: http://localhost:6111/app/kibana#/management
[00:00:43]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1582282680884511981] [.kibana] creating index, cause [auto(bulk api)], templates [], shards [1]/[1], mappings []
[00:00:43]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1582282680884511981] [.kibana/WbxG9NkUSS2jSojtMRj1hg] create_mapping [_doc]
[00:00:44]             │ debg ... sleep(700) start
[00:00:44]             │ debg browser[INFO] http://localhost:6111/app/kibana?_t=1582284617651#/management 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:44]             │
[00:00:44]             │ debg browser[INFO] http://localhost:6111/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:45]             │ debg ... sleep(700) end
[00:00:45]             │ debg returned from get, calling refresh
[00:00:45]             │ debg browser[INFO] http://localhost:6111/app/kibana?_t=1582284617651#/management 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:45]             │
[00:00:45]             │ debg browser[INFO] http://localhost:6111/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:46]             │ debg currentUrl = http://localhost:6111/app/kibana#/management
[00:00:46]             │          appUrl = http://localhost:6111/app/kibana#/management
[00:00:46]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:48]             │ debg TestSubjects.find(kibanaChrome)
[00:00:48]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:00:48]             │ debg browser[INFO] http://localhost:6111/bundles/plugin/testbed/testbed.plugin.js 171:12 "Testbed plugin set up. uiProp: 'Accessible from client'"
[00:00:48]             │ debg browser[INFO] http://localhost:6111/bundles/plugin/data/data.plugin.js 35735:15 "INFO: 2020-02-21T11:30:21Z
[00:00:48]             │        Adding connection to http://localhost:6111/elasticsearch
[00:00:48]             │
[00:00:48]             │      "
[00:00:48]             │ debg browser[DEBUG] http://localhost:6111/bundles/plugin/usageCollection/usageCollection.plugin.js 33484:16 "Reporting user-agent."
[00:00:48]             │ debg browser[INFO] http://localhost:6111/bundles/plugin/testbed/testbed.plugin.js 179:12 "Testbed plugin started"
[00:00:48]             │ debg ... sleep(501) start
[00:00:49]             │ debg ... sleep(501) end
[00:00:49]             │ debg in navigateTo url = http://localhost:6111/app/kibana#/management?_g=()
[00:00:49]             │ debg TestSubjects.exists(statusPageContainer)
[00:00:49]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:00:51]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:00:52]             │ debg click "Embeddable explorer" app link
[00:00:52]             │ debg TestSubjects.find(navDrawer)
[00:00:52]             │ debg Find.findByCssSelector('[data-test-subj="navDrawer"]') with timeout=10000
[00:00:56]           └-: creating and adding children
[00:00:56]             └-> "before all" hook
[00:00:56]             └-> "before all" hook
[00:00:56]               │ debg TestSubjects.click(embeddablePanelExamplae)
[00:00:56]               │ debg Find.clickByCssSelector('[data-test-subj="embeddablePanelExamplae"]') with timeout=10000
[00:00:56]               │ debg Find.findByCssSelector('[data-test-subj="embeddablePanelExamplae"]') with timeout=10000
[00:00:56]             └-> Can create a new child
[00:00:56]               └-> "before each" hook: global before each
[00:00:56]               │ debg TestSubjects.click(embeddablePanelToggleMenuIcon)
[00:00:56]               │ debg Find.clickByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=10000
[00:00:56]               │ debg Find.findByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=10000
[00:00:56]               │ debg TestSubjects.click(embeddablePanelAction-ADD_PANEL_ACTION_ID)
[00:00:56]               │ debg Find.clickByCssSelector('[data-test-subj="embeddablePanelAction-ADD_PANEL_ACTION_ID"]') with timeout=10000
[00:00:56]               │ debg Find.findByCssSelector('[data-test-subj="embeddablePanelAction-ADD_PANEL_ACTION_ID"]') with timeout=10000
[00:00:57]               │ debg TestSubjects.click(createNew)
[00:00:57]               │ debg Find.clickByCssSelector('[data-test-subj="createNew"]') with timeout=10000
[00:00:57]               │ debg Find.findByCssSelector('[data-test-subj="createNew"]') with timeout=10000
[00:00:57]               │ debg TestSubjects.click(createNew-TODO_EMBEDDABLE)
[00:00:57]               │ debg Find.clickByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:00:57]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:07]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:07]               │      Wait timed out after 10050ms
[00:01:07]               │ERROR browser[SEVERE] http://localhost:6111/api/saved_objects/_find?default_search_operator=AND&fields=title&page=1&per_page=1000&search_fields=title%5E3&search_fields=description& - Failed to load resource: the server responded with a status of 400 (Bad Request)
[00:01:07]               │ debg browser[INFO] http://localhost:6111/bundles/commons.bundle.js 7782:18 "Detected an unhandled Promise rejection.
[00:01:07]               │      Error: Bad Request"
[00:01:07]               │ERROR browser[SEVERE] http://localhost:6111/bundles/commons.bundle.js 8529:12 
[00:01:07]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:17]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:17]               │      Wait timed out after 10026ms
[00:01:18]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:28]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:28]               │      Wait timed out after 10057ms
[00:01:28]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:39]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:39]               │      Wait timed out after 10058ms
[00:01:39]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:01:49]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:01:49]               │      Wait timed out after 10007ms
[00:01:50]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:00]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:00]               │      Wait timed out after 10044ms
[00:02:00]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:10]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:10]               │      Wait timed out after 10038ms
[00:02:11]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:21]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:21]               │      Wait timed out after 10023ms
[00:02:21]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:24]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1582282680884511981] [.kibana/WbxG9NkUSS2jSojtMRj1hg] update_mapping [_doc]
[00:02:31]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:31]               │      Wait timed out after 10016ms
[00:02:32]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:42]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:42]               │      Wait timed out after 10025ms
[00:02:42]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:02:52]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:02:52]               │      Wait timed out after 10058ms
[00:02:53]               │ debg Find.findByCssSelector('[data-test-subj="createNew-TODO_EMBEDDABLE"]') with timeout=10000
[00:03:03]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
[00:03:03]               │      Wait timed out after 10014ms
[00:03:03]               │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/embeddable explorer creating and adding children Can create a new child.png"
[00:03:03]               │ info Current URL is: http://localhost:6111/app/embeddableExplorer/embeddablePanelExamplae
[00:03:03]               │ info Saving page source to: /dev/shm/workspace/kibana/test/examples/failure_debug/html/embeddable explorer creating and adding children Can create a new child.html
[00:03:03]               └- ✖ fail: "embeddable explorer creating and adding children Can create a new child"
[00:03:03]               │

Stack Trace

Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="createNew-TODO_EMBEDDABLE"])
Wait timed out after 10014ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:841:17
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit f3137a2 into elastic:7.x Feb 21, 2020
@afgomez afgomez deleted the backport/7.x/pr-58104 branch February 21, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants