Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[presentation] Remove export* syntax from plugin index files #110893

Closed
spalger opened this issue Sep 1, 2021 · 1 comment · Fixed by #145633
Closed

[presentation] Remove export* syntax from plugin index files #110893

spalger opened this issue Sep 1, 2021 · 1 comment · Fixed by #145633
Labels
chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@spalger
Copy link
Contributor

spalger commented Sep 1, 2021

See #57370 for reasoning, but the gist is that export * usage leads to unexpected and excessive exports from the plugin, leading the public API to grow and increasing the cost of maintaining backwards compatibility.

#109357 implements an ESLint rule to check for this that also assists in fixing the rule, though the auto-fix is imperfect and will require some manual review before committing.

Please remove the /* eslint-disable @kbn/eslint/no_export_all */ comment(s) added in #109357 from the relevant files, validate the auto-fix, remove unnecessary exports, and then submit a PR. Thank you!

Hint: You can search for the URL of this issue to find specific occurrences
@spalger spalger added chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nickpeihl nickpeihl mentioned this issue Nov 18, 2022
Merged
nickpeihl added a commit that referenced this issue Nov 18, 2022
@nickpeihl @kibanamachine
[Presentation] Remove uses of export * from in Presentation Util pl…
92fb6fc 
…ugin (#145633)

Fixes #110893

## Summary
Replaces uses of `export *` with of explicit imports in
`public/index.ts` in Presentation Util plugin.



For reviewers: 

This may look daunting as it touches many files across several plugins.
I recommend looking at the [change on this line
first](https://github.com/elastic/kibana/pull/145633/files#diff-64c9d44d43fb458b5f18b066887586eee3868c6ab1ea7fcb82254d40a0fb53f4L34).
Prior to this PR this line exports modules from the `common/lib`
directory in the `public` module. This should not be necessary since
other plugins should be able to access these modules from
`@kbn/presentation-util-plugin/common` directly.

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Presentation] Remove uses of export * from in Presentation Util plugin nickpeihl/kibana
2 participants
@spalger @elasticmachine