Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible line on series when using "Offset series time by" on TSVB with series Stacked #120870

Closed
Kilhog opened this issue Dec 9, 2021 · 7 comments
Labels
blocked bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@Kilhog
Copy link

Kilhog commented Dec 9, 2021

Kibana version: 7.15.2
Elasticsearch version: 7.15.2
Server OS version: Latest Docker
Browser version: Safari
Browser OS version: 15.1
Original install method (e.g. download page, yum, from source, etc.): Docker
Describe the bug:

When I try do make a TSBV with my current data on 1 year (01/01/2021 - 31/12/2021), and add a second series on the same graph with the same parameters except the "Offset series time by" set to 1y, I have a weird behaviour. The line of the first series (without time shift) is not displayed, but I can still view the data with the "popover dialog"

Steps to reproduce:

  1. Create TSVB with a first series (cumulative sum, grouped by terms, with Chart type: line and Stacked: stacked)
  2. Create a second series (cumulative sum with no grouped by, with Chart type: line and Stacked: none and time shift 1y)
  3. Use time range from 01/01 to 31/12
  4. Offset the second series by 1 year

PS : It's maybe related to a other issue I reported #120449, the only different between the two behaviour is the time range. And another hint, if I set the graph type to "bar" the bar correctly show up.

Expected behavior:

Chart line correctly draw

Screenshots (if relevant):

Graph bug :

Screenshot 2021-12-09 at 09 12 58

Screenshot 2021-12-09 at 09 12 53

(Graph with bars instead of lines)

Screenshot 2021-12-09 at 09 15 48

First series configuration :

Screenshot 2021-12-05 at 11 37 11

Screenshot 2021-12-05 at 11 37 05

Second series configuration :

Screenshot 2021-12-05 at 11 37 30

Screenshot 2021-12-05 at 11 37 23

@Kilhog Kilhog added the bug Fixes for quality problems that affect the customer experience label Dec 9, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 9, 2021
@flash1293 flash1293 added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed and removed needs-team Issues missing a team label labels Dec 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula
Copy link
Contributor

@Kilhog we could also reproduce this. We are not 100% sure why this happens. The problem is that the timeseries interval changes from 24hours to 7days. If you change the interval to 1d, you will be able to see your series

image

@Kilhog
Copy link
Author

Kilhog commented Jan 5, 2022

@stratoula Yes indeed, with 1d interval I see the series
Screenshot 2022-01-05 at 13 54 18

@flash1293
Copy link
Contributor

After investigation, the problem happening here is that the shift is not compatible to the interval (a year is not evenly dividable by weeks) which causes a chart with gaps between data points. For the stacked area chart these gaps cause the series to not get rendered.

The following things can be done to work around this problem:

  • Make sure the interval and the time shift are compatible by setting the interval (in this case by setting the interval to daily)
  • Make sure the interval and the time shift are compatible by setting the shift (in this case using 52 weeks instead of 1y)
  • Switch to Lens - besides the two workaround stated above, Lens allows you to configure the way gaps in the chart are handled and it's possible to interpolate between them

@flash1293 flash1293 added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed triage_needed labels Jan 10, 2022
@flash1293
Copy link
Contributor

Discussed this offline and we decided to not extend TSVB with additional features to render the line differently for situations like this. However, we will soon get to #117280 which allows you to do the same thing in Lens. Together with #116424 it will be very easy to migrate existing configurations over.

@flash1293
Copy link
Contributor

Blocked on #117280

@flash1293
Copy link
Contributor

As #117280 has been merged, this is now possible to do in Lens. To make it work with TSVB, see the comment above #120870 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants