Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] - cannot upload image in 8.7 #154356

Closed
Rossall82 opened this issue Apr 4, 2023 · 1 comment · Fixed by #154385
Closed

[Canvas] - cannot upload image in 8.7 #154356

Rossall82 opened this issue Apr 4, 2023 · 1 comment · Fixed by #154385
Assignees
@nickpeihl
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Rossall82
Copy link

Kibana version:
8.7.0

Elasticsearch version:
8.7.0

Browser version:
Chrome 111.0.5563.146 and Firefox 111.0.1

Describe the bug:
If you go to Canvas > Create Workpad > Add element > Image > Image the Elastic logo is dropped onto the workpad. When you click once on that, the "Selected element" menu in 8.6 contains the Image upload options of Import or Link, but with 8.7 we see a textbox with null in it, and a tooltip that reads: "The interface for this argument could not parse the value, so a fallback input is being used".

Steps to reproduce:

  1. Go to Canvas > Create Workpad > Add element > Image > Image and the Elastic logo is dropped onto the workpad.
  2. Click once on that, the "Selected element" menu in version 8.6 contains the Image upload options of Import or Link, but with 8.7 we see a textbox with null in it, and a tooltip that reads: "The interface for this argument could not parse the value, so a fallback input is being used".

Expected behavior:
Import or Link options should appear on the right hand side

Screenshots (if relevant):
v86Example
v87Example
@Rossall82 Rossall82 added the bug Fixes for quality problems that affect the customer experience label Apr 4, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 4, 2023
@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Feature:Canvas and removed needs-team Issues missing a team label labels Apr 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nickpeihl nickpeihl self-assigned this Apr 4, 2023
@nickpeihl nickpeihl mentioned this issue Apr 4, 2023
Merged
nickpeihl added a commit that referenced this issue Apr 4, 2023
@nickpeihl
[Canvas] Fix image upload component not loading for image elements (#…
8724518 
…154385)

## Summary

Fixes a regression where the image upload component does not load for
Canvas image elements.

Starting with PR #145633 modules in
`@kbn/presentation-util-plugin/common` are no longer exported from the
`@kbn/presentation-util-plugin/public` module. The imports in the
`ImageUpload` module should have also been updated to the
`@kbn/presentation-util-plugin/common` module.

Fixes #154356
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Apr 4, 2023
@nickpeihl
[Canvas] Fix image upload component not loading for image elements (e…
6063d23 
…lastic#154385)

## Summary

Fixes a regression where the image upload component does not load for
Canvas image elements.

Starting with PR elastic#145633 modules in
`@kbn/presentation-util-plugin/common` are no longer exported from the
`@kbn/presentation-util-plugin/public` module. The imports in the
`ImageUpload` module should have also been updated to the
`@kbn/presentation-util-plugin/common` module.

Fixes elastic#154356

(cherry picked from commit 8724518)
kibanamachine added a commit that referenced this issue Apr 4, 2023
@kibanamachine @nickpeihl
[8.7] [Canvas] Fix image upload component not loading for image eleme…
3920693 
…nts (#154385) (#154393)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Canvas] Fix image upload component not loading for image elements
(#154385)](#154385)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nick
Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2023-04-04T20:38:58Z","message":"[Canvas]
Fix image upload component not loading for image elements
(#154385)\n\n## Summary\r\n\r\nFixes a regression where the image upload
component does not load for\r\nCanvas image elements.\r\n\r\nStarting
with PR #145633 modules in\r\n`@kbn/presentation-util-plugin/common` are
no longer exported from the\r\n`@kbn/presentation-util-plugin/public`
module. The imports in the\r\n`ImageUpload` module should have also been
updated to the\r\n`@kbn/presentation-util-plugin/common`
module.\r\n\r\nFixes
#154356","sha":"8724518804e1755587de90b9d22a9a04512d2ea6","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","loe:hours","impact:high","Feature:Canvas","v8.8.0","v8.7.1"],"number":154385,"url":"https://github.com/elastic/kibana/pull/154385","mergeCommit":{"message":"[Canvas]
Fix image upload component not loading for image elements
(#154385)\n\n## Summary\r\n\r\nFixes a regression where the image upload
component does not load for\r\nCanvas image elements.\r\n\r\nStarting
with PR #145633 modules in\r\n`@kbn/presentation-util-plugin/common` are
no longer exported from the\r\n`@kbn/presentation-util-plugin/public`
module. The imports in the\r\n`ImageUpload` module should have also been
updated to the\r\n`@kbn/presentation-util-plugin/common`
module.\r\n\r\nFixes
#154356","sha":"8724518804e1755587de90b9d22a9a04512d2ea6"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/154385","number":154385,"mergeCommit":{"message":"[Canvas]
Fix image upload component not loading for image elements
(#154385)\n\n## Summary\r\n\r\nFixes a regression where the image upload
component does not load for\r\nCanvas image elements.\r\n\r\nStarting
with PR #145633 modules in\r\n`@kbn/presentation-util-plugin/common` are
no longer exported from the\r\n`@kbn/presentation-util-plugin/public`
module. The imports in the\r\n`ImageUpload` module should have also been
updated to the\r\n`@kbn/presentation-util-plugin/common`
module.\r\n\r\nFixes
#154356","sha":"8724518804e1755587de90b9d22a9a04512d2ea6"}},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickpeihl nickpeihl

Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Canvas] Fix image upload component not loading for image elements nickpeihl/kibana
4 participants
@nickpeihl @Rossall82 @ThomThomson @elasticmachine