Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.7] [Canvas] Fix image upload component not loading for image elements (#154385) #154393

Merged
merged 1 commit into from
Apr 4, 2023
Merged

[8.7] [Canvas] Fix image upload component not loading for image elements (#154385) #154393

merged 1 commit into from
Apr 4, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.7:

Questions ?

Please refer to the Backport tool documentation

@nickpeihl
[Canvas] Fix image upload component not loading for image elements (e…
6063d23 
…lastic#154385)

## Summary

Fixes a regression where the image upload component does not load for
Canvas image elements.

Starting with PR elastic#145633 modules in
`@kbn/presentation-util-plugin/common` are no longer exported from the
`@kbn/presentation-util-plugin/public` module. The imports in the
`ImageUpload` module should have also been updated to the
`@kbn/presentation-util-plugin/common` module.

Fixes elastic#154356

(cherry picked from commit 8724518)
@kibanamachine kibanamachine enabled auto-merge (squash) April 4, 2023 20:44
@kibanamachine kibanamachine mentioned this pull request Apr 4, 2023
Merged
@kibanamachine kibanamachine merged commit 3920693 into elastic:8.7 Apr 4, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
presentationUtil 161 166 +5

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
presentationUtil 7 8 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1023.6KB 1023.6KB -9.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
presentationUtil 40.4KB 40.6KB +178.0B
Unknown metric groups

API count

id before after diff
presentationUtil 217 222 +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nickpeihl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nickpeihl nickpeihl

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @nickpeihl