Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/observability/custom_threshold_rule/custom_eq_avg_bytes_fired·ts - Observability Rules Rules Endpoints Custom Threshold rule - CUSTOM_EQ - AVG - BYTES - FIRED Rule creation should set correct information in the alert document #175360

Closed
kibanamachine opened this issue Jan 24, 2024 · 11 comments · Fixed by #175479
Closed

Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/observability/custom_threshold_rule/custom_eq_avg_bytes_fired·ts - Observability Rules Rules Endpoints Custom Threshold rule - CUSTOM_EQ - AVG - BYTES - FIRED Rule creation should set correct information in the alert document #175360

kibanamachine opened this issue Jan 24, 2024 · 11 comments · Fixed by #175479
Assignees
@simianhacker
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:obs-ux-management Observability Management User Experience Team

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 24, 2024 •
edited
Loading

A test failed on a tracked branch

Error: expected { 'kibana.alert.rule.parameters': 
   { criteria: [ [Object] ],
     alertOnNoData: true,
     alertOnGroupDisappear: true,
     searchConfiguration: { query: [Object], index: 'data-view-id' } },
  'kibana.alert.rule.category': 'Custom threshold (Beta)',
  'kibana.alert.rule.consumer': 'logs',
  'kibana.alert.rule.execution.uuid': '54a48794-e923-4a29-ba23-cd0cad0a38d0',
  'kibana.alert.rule.name': 'Threshold rule',
  'kibana.alert.rule.producer': 'observability',
  'kibana.alert.rule.revision': 0,
  'kibana.alert.rule.rule_type_id': 'observability.rules.custom_threshold',
  'kibana.alert.rule.uuid': '21baf4ff-4305-4c94-bfba-c62eff45268e',
  'kibana.space_ids': [ 'default' ],
  'kibana.alert.rule.tags': [ 'observability' ],
  '@timestamp': '2024-01-24T00:41:51.492Z',
  'kibana.alert.reason': 'Custom equation reported no data in the last 1m',
  'kibana.alert.action_group': 'custom_threshold.nodata',
  'kibana.alert.evaluation.values': [ null ],
  tags: [ 'observability' ],
  'kibana.alert.duration.us': 0,
  'kibana.alert.time_range': { gte: '2024-01-24T00:41:51.492Z' },
  'kibana.alert.instance.id': '*',
  'kibana.alert.start': '2024-01-24T00:41:51.492Z',
  'kibana.alert.uuid': '9aaa22c5-87f1-4608-99d0-d6fbcb8d6fb1',
  'kibana.alert.status': 'active',
  'kibana.alert.workflow_status': 'open',
  'event.kind': 'signal',
  'event.action': 'open',
  'kibana.version': '8.13.0-SNAPSHOT',
  'kibana.alert.flapping': false } to have a property 'kibana.alert.action_group' of 'custom_threshold.fired', but got 'custom_threshold.nodata'
    at Assertion.assert (expect.js:100:11)
    at Assertion.property (expect.js:417:10)
    at Context.<anonymous> (custom_eq_avg_bytes_fired.ts:185:43)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jan 24, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 24, 2024
@mistic mistic closed this as completed Jan 24, 2024
@kibanamachine kibanamachine reopened this Jan 24, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@delanni
Copy link
Contributor

delanni commented Jan 24, 2024 •
edited
Loading

Probably related: #175359, this also started after #174559 was merged

@mistic mistic closed this as completed Jan 24, 2024
@kibanamachine kibanamachine reopened this Jan 24, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@mistic mistic added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Jan 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 24, 2024
@simianhacker
Copy link
Member

I'm looking into this with #175479

@simianhacker simianhacker mentioned this issue Jan 24, 2024
Merged
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Jan 25, 2024
@mistic
skip flaky suite (#175360)
ee72277
@mistic
Copy link
Member

mistic commented Jan 25, 2024

Skipped.

main: ee72277

@smith smith removed the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Jan 26, 2024
maryam-saeidi added a commit that referenced this issue Jan 26, 2024
@simianhacker @maryam-saeidi
[Obs-UX-Mgmt] Fixing flaky test for Custom Threshold rule (#175479)
c8ada33 
## Summary

This PR fixes #175407 by increasing the rule lookback to 5 minutes to
try and avoid picking up 2 buckets since we can't control the exact time
of the rule execution to ensure accuracy and consistency. 😦

Fixes #175360

[Flaky Test Runner
Results](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4959)

---------

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@mistic @CoenWarmer
skip flaky suite (elastic#175360)
d57e53e
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@simianhacker @maryam-saeidi @CoenWarmer
[Obs-UX-Mgmt] Fixing flaky test for Custom Threshold rule (elastic#17…
7251ffb 
…5479)

## Summary

This PR fixes elastic#175407 by increasing the rule lookback to 5 minutes to
try and avoid picking up 2 buckets since we can't control the exact time
of the rule execution to ensure accuracy and consistency. 😦

Fixes elastic#175360

[Flaky Test Runner
Results](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4959)

---------

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simianhacker simianhacker

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Obs-UX-Mgmt] Fixing flaky test for Custom Threshold rule simianhacker/kibana
6 participants
@smith @simianhacker @mistic @delanni @elasticmachine @kibanamachine