[Obs-UX-Mgmt] Fixing flaky test for Custom Threshold rule #175479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…n the test is run we can't accurately check the doc_count since it could include 5-6 buckets.
simianhacker
changed the title
simianhacker
added
release_note:skip
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
maryam-saeidi
approved these changes
Jan 26, 2024
...k/test/alerting_api_integration/observability/custom_threshold_rule/documents_count_fired.ts
Outdated
Show resolved
Hide resolved
...st/alerting_api_integration/observability/custom_threshold_rule/custom_eq_avg_bytes_fired.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…5479) ## Summary This PR fixes elastic#175407 by increasing the rule lookback to 5 minutes to try and avoid picking up 2 buckets since we can't control the exact time of the rule execution to ensure accuracy and consistency. 😦 Fixes elastic#175360 [Flaky Test Runner Results](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4959) --------- Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #175407 by increasing the rule lookback to 5 minutes to try and avoid picking up 2 buckets since we can't control the exact time of the rule execution to ensure accuracy and consistency. 😦
Fixes #175360
Flaky Test Runner Results