Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Ad-hoc Data Views for testing models in Trained Models UI #177633

Closed
darnautov opened this issue Feb 22, 2024 · 3 comments · Fixed by #180795
Closed

[ML] Ad-hoc Data Views for testing models in Trained Models UI #177633

darnautov opened this issue Feb 22, 2024 · 3 comments · Fixed by #180795
Assignees
Labels
Feature:3rd Party Models ML 3rd party models :ml Team:ML Team label for ML (also use :ml) v8.14.0

Comments

@darnautov
Copy link
Contributor

darnautov commented Feb 22, 2024

Currently to retrieve a list of text fields from the source data to test a model output we rely on Kibana Data Views. For users who mostly use the Elasticsearch API to ingest data and are not familiar with the concept of data views, it might be an unnecessary friction point. We can improve the UX by providing ad-hoc data views either for

  1. all indices containing text fields

or

  1. narrowing down the list to indices that utilize ingest pipelines with inference processors of the testing model
@darnautov darnautov added :ml Feature:3rd Party Models ML 3rd party models Team:ML Team label for ML (also use :ml) labels Feb 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@serenachou
Copy link

serenachou commented Apr 12, 2024

@joemcelroy - how do you flag that semantic_text or dense_vector is being used for Playground? Should we use similar logic to what's proposed here for #2 option?

@darnautov we could potentially also key off of semantic_text field mapping being present?

@joemcelroy
Copy link
Member

In playground we perform a field-caps API request and a single hit query to gather the schema and the model_id that was used for inference.

Im expecting when semantic_text lands, the field type will be semantic or similar which the field caps API will help on.

We don't need to get the pipeline processor as I get the model_id from the hit itself but its another option to get the model_id.

darnautov added a commit that referenced this issue Apr 16, 2024
## Summary

Closes #177633

- Renames "Index" form control to "Data View" 
- Enables users to create persistent/ad-hoc data view from the Test
model flyout

<img width="600" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/d41b0396-86e8-4f79-8d3f-005469d17d60">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:3rd Party Models ML 3rd party models :ml Team:ML Team label for ML (also use :ml) v8.14.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants