Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adds support for ad-hoc Data Views for testing models in Trained Models UI #180795

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Apr 15, 2024

Summary

Closes #177633

  • Renames "Index" form control to "Data View"
  • Enables users to create persistent/ad-hoc data view from the Test model flyout
image

Checklist

@darnautov darnautov added release_note:enhancement :ml Feature:3rd Party Models ML 3rd party models Team:ML Team label for ML (also use :ml) v8.14.0 labels Apr 15, 2024
@darnautov darnautov self-assigned this Apr 15, 2024
@darnautov darnautov requested a review from a team as a code owner April 15, 2024 12:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov requested a review from peteharverson April 15, 2024 13:40
Copy link
Member

@joemcelroy joemcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for indices without data views

image

@darnautov darnautov force-pushed the ml-177633-ad-hoc-data-views branch from e6e91e2 to 6ff569b Compare April 16, 2024 12:38
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edits with the flyout for creating data views and LGTM

@darnautov darnautov enabled auto-merge (squash) April 16, 2024 15:17
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #18 / Agents fleet_list_agent should return correct status summary if showUpgradeable is provided

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.1MB 4.1MB +596.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 2c4f1a2 into elastic:main Apr 16, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 16, 2024
@serenachou
Copy link

LGTM!

This is fine for 8.14 to try it out - it's certainly better than no call to action to create the dependency!
So the takeaways are : there's a new dropdown for Data Views and the customer can select one or create one and when clicking the Create Data View it slides out the normal flyout for creation.
If that's correct - that matches exactly what I needed to make that dependency more clear. Thank you!

@darnautov darnautov deleted the ml-177633-ad-hoc-data-views branch April 17, 2024 11:47
@peteharverson peteharverson changed the title [ML] Ad-hoc Data Views for testing models in Trained Models UI [ML] Adds support for ad-hoc Data Views for testing models in Trained Models UI Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:3rd Party Models ML 3rd party models :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Ad-hoc Data Views for testing models in Trained Models UI
7 participants