-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adds support for ad-hoc Data Views for testing models in Trained Models UI #180795
[ML] Adds support for ad-hoc Data Views for testing models in Trained Models UI #180795
Conversation
Pinging @elastic/ml-ui (:ml) |
x-pack/plugins/ml/public/application/model_management/test_models/models/index_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/model_management/test_models/models/index_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/model_management/test_models/models/index_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/model_management/test_models/models/index_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/model_management/test_models/models/index_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/model_management/test_models/models/index_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/model_management/test_models/models/index_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/model_management/test_models/models/index_input.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e6e91e2
to
6ff569b
Compare
...plugins/ml/public/application/components/create_data_view_button/create_data_view_button.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest edits with the flyout for creating data views and LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @darnautov |
LGTM!
|
Summary
Closes #177633
Checklist