Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Version rule update API #179476

Closed
JiaweiWu opened this issue Mar 26, 2024 · 2 comments
Closed

[RAM] Version rule update API #179476

JiaweiWu opened this issue Mar 26, 2024 · 2 comments
Assignees
@JiaweiWu
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.14.0

Comments

@JiaweiWu
Copy link
Contributor

Parent issue: #157883
@JiaweiWu JiaweiWu added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.14.0 labels Mar 26, 2024
@JiaweiWu JiaweiWu self-assigned this Mar 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@JiaweiWu JiaweiWu moved this from Awaiting Triage to In Progress in AppEx: ResponseOps - Rules & Alerts Management Mar 26, 2024
@JiaweiWu JiaweiWu mentioned this issue Mar 27, 2024
Merged
1 task
@JiaweiWu JiaweiWu moved this from In Progress to In Review in AppEx: ResponseOps - Rules & Alerts Management Mar 27, 2024
JiaweiWu added a commit that referenced this issue Apr 15, 2024
@JiaweiWu @kibanamachine
[RAM][HTTP Versioning] Version Public Rule Update Route (#179587)
ed4fade 
## Summary

Issue: #179476
Parent issue: #157883

This PR versions the update (`PUT '/api/alerting/rule/{id}'`) route.
Still using `config-schema` for now, even though we will eventually
switch to `zod` when core is ready with openapi doc generation support
in the versioned router.

We are now validating update data using the update data schema when
calling `rulesClient->update`. We are also validating (but not throwing)
the updated rule as well.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@cnasikas
Copy link
Member

cnasikas commented May 1, 2024

Implemented by #179587

@cnasikas cnasikas closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiaweiWu JiaweiWu

Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.14.0
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cnasikas @elasticmachine @JiaweiWu