[RAM][HTTP Versioning] Version Public Rule Update Route #179587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaweiWu
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
@elasticmachine merge upstream |
JiaweiWu
changed the title
54 tasks
umbopepato
reviewed
Mar 28, 2024
| @@ -63,7 +63,7 @@ describe('updateAlertRoute', () => { | |||
|
|
|||
| expect(config.path).toMatchInlineSnapshot(`"/api/alerts/alert/{id}"`); | |||
|
|
|||
| rulesClient.update.mockResolvedValueOnce(mockedResponse); | |||
| rulesClient.update.mockResolvedValueOnce(mockedResponse as unknown as SanitizedRule); | |||
There was a problem hiding this comment.
nit: how about using only one type assertion when mockedResponse is declared?
4 tasks
Zacqary
reviewed
Mar 28, 2024
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
JiaweiWu
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue: #179476
Parent issue: #157883
This PR versions the update (
PUT '/api/alerting/rule/{id}') route. Still usingconfig-schemafor now, even though we will eventually switch tozodwhen core is ready with openapi doc generation support in the versioned router.We are now validating update data using the update data schema when calling
rulesClient->update. We are also validating (but not throwing) the updated rule as well.Checklist