Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Rules] Version the rest of rule's public APIs #195181

Closed
4 tasks done
cnasikas opened this issue Oct 7, 2024 · 3 comments · Fixed by #196690
Closed
4 tasks done

[ResponseOps][Rules] Version the rest of rule's public APIs #195181

cnasikas opened this issue Oct 7, 2024 · 3 comments · Fixed by #196690
Assignees
@jcger
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@cnasikas
Copy link
Member

cnasikas commented Oct 7, 2024 •
edited
Loading

Towards #187356 we should version the following API routes

API Routes
Beta Give feedback
@cnasikas cnasikas added Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

This was referenced Oct 7, 2024
Open
Closed
@cnasikas cnasikas changed the title ResponseOps][Rules] Version the rest of rule's public APIs [ResponseOps][Rules] Version the rest of rule's public APIs Oct 7, 2024
This was referenced Oct 8, 2024
Merged
Merged
@jcger
Copy link
Contributor

jcger commented Oct 9, 2024

what about the legacy mute and unmute_all endpoints? https://github.com/elastic/kibana/blob/main/x-pack/plugins/alerting/server/routes/legacy/mute_all.ts

@jcger jcger mentioned this issue Oct 9, 2024
Closed
@cnasikas
Copy link
Member Author

@jcger We do not want to version legacy endpoints as they are deprecated and we will remove them in 9.0.

@jcger jcger mentioned this issue Oct 14, 2024
Merged
jcger added a commit that referenced this issue Oct 14, 2024
@jcger
[Response Ops][Rules] Version Mute All Rule API (#195572)
f787b85 
## Summary

`POST /api/alerting/rule/{id}/_mute_all` in
#195181
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 14, 2024
@jcger
[Response Ops][Rules] Version Mute All Rule API (elastic#195572)
939c210 
## Summary

`POST /api/alerting/rule/{id}/_mute_all` in
elastic#195181

(cherry picked from commit f787b85)
kibanamachine added a commit that referenced this issue Oct 14, 2024
@kibanamachine @jcger
[8.x] [Response Ops][Rules] Version Mute All Rule API (#195572) (#196125
7aa0e2a 
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Response Ops][Rules] Version Mute All Rule API
(#195572)](#195572)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julian
Gernun","email":"17549662+jcger@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-14T12:18:42Z","message":"[Response
Ops][Rules] Version Mute All Rule API (#195572)\n\n##
Summary\r\n\r\n`POST /api/alerting/rule/{id}/_mute_all`
in\r\nhttps://github.com//issues/195181","sha":"f787b852b23139fbc8e9926263d827ded4a1f451","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Response
Ops][Rules] Version Mute All Rule
API","number":195572,"url":"https://github.com/elastic/kibana/pull/195572","mergeCommit":{"message":"[Response
Ops][Rules] Version Mute All Rule API (#195572)\n\n##
Summary\r\n\r\n`POST /api/alerting/rule/{id}/_mute_all`
in\r\nhttps://github.com//issues/195181","sha":"f787b852b23139fbc8e9926263d827ded4a1f451"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195572","number":195572,"mergeCommit":{"message":"[Response
Ops][Rules] Version Mute All Rule API (#195572)\n\n##
Summary\r\n\r\n`POST /api/alerting/rule/{id}/_mute_all`
in\r\nhttps://github.com//issues/195181","sha":"f787b852b23139fbc8e9926263d827ded4a1f451"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
jcger added a commit that referenced this issue Oct 14, 2024
@jcger
[Response Ops][Rules] Version Unmute All Rule API (#196070)
c901fec 
## Summary

`POST /api/alerting/rule/{id}/_unmute_all` in
#195181
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 14, 2024
@jcger
[Response Ops][Rules] Version Unmute All Rule API (elastic#196070)
1bf55f9 
## Summary

`POST /api/alerting/rule/{id}/_unmute_all` in
elastic#195181

(cherry picked from commit c901fec)
jcger added a commit that referenced this issue Oct 14, 2024
@jcger
[Response Ops][Rules] Version Get Rule Types API (#195361)
512a31d 
## Summary

`GET /api/alerting/rule_types` item in
#195181
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 14, 2024
@jcger
[Response Ops][Rules] Version Get Rule Types API (elastic#195361)
d7f4942 
## Summary

`GET /api/alerting/rule_types` item in
elastic#195181

(cherry picked from commit 512a31d)
kibanamachine added a commit that referenced this issue Oct 14, 2024
@kibanamachine @jcger
[8.x] [Response Ops][Rules] Version Unmute All Rule API (#196070) (#1…
fadc976 
…96170)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Response Ops][Rules] Version Unmute All Rule API
(#196070)](#196070)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julian
Gernun","email":"17549662+jcger@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-14T15:28:57Z","message":"[Response
Ops][Rules] Version Unmute All Rule API (#196070)\n\n##
Summary\r\n\r\n`POST /api/alerting/rule/{id}/_unmute_all`
in\r\nhttps://github.com//issues/195181","sha":"c901fec4f1ea9407265e6f450a5a9390fa31454b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Response
Ops][Rules] Version Unmute All Rule
API","number":196070,"url":"https://github.com/elastic/kibana/pull/196070","mergeCommit":{"message":"[Response
Ops][Rules] Version Unmute All Rule API (#196070)\n\n##
Summary\r\n\r\n`POST /api/alerting/rule/{id}/_unmute_all`
in\r\nhttps://github.com//issues/195181","sha":"c901fec4f1ea9407265e6f450a5a9390fa31454b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196070","number":196070,"mergeCommit":{"message":"[Response
Ops][Rules] Version Unmute All Rule API (#196070)\n\n##
Summary\r\n\r\n`POST /api/alerting/rule/{id}/_unmute_all`
in\r\nhttps://github.com//issues/195181","sha":"c901fec4f1ea9407265e6f450a5a9390fa31454b"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
kibanamachine added a commit that referenced this issue Oct 15, 2024
@kibanamachine @jcger
[8.x] [Response Ops][Rules] Version Get Rule Types API (#195361) (#19…
c156cb3 
…6175)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Response Ops][Rules] Version Get Rule Types API
(#195361)](#195361)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julian
Gernun","email":"17549662+jcger@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-14T15:46:17Z","message":"[Response
Ops][Rules] Version Get Rule Types API (#195361)\n\n##
Summary\r\n\r\n`GET /api/alerting/rule_types` item
in\r\nhttps://github.com//issues/195181","sha":"512a31d7a1e42139c2e1b26e961b2226ace3836d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Response
Ops][Rules] Version Get Rule Types
API","number":195361,"url":"https://github.com/elastic/kibana/pull/195361","mergeCommit":{"message":"[Response
Ops][Rules] Version Get Rule Types API (#195361)\n\n##
Summary\r\n\r\n`GET /api/alerting/rule_types` item
in\r\nhttps://github.com//issues/195181","sha":"512a31d7a1e42139c2e1b26e961b2226ace3836d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195361","number":195361,"mergeCommit":{"message":"[Response
Ops][Rules] Version Get Rule Types API (#195361)\n\n##
Summary\r\n\r\n`GET /api/alerting/rule_types` item
in\r\nhttps://github.com//issues/195181","sha":"512a31d7a1e42139c2e1b26e961b2226ace3836d"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
@jcger jcger mentioned this issue Oct 17, 2024
Merged
jcger added a commit that referenced this issue Oct 18, 2024
@jcger
[Response Ops][Alerting] HTTP Version health API (#196690)
c1ac722 
## Summary

Closes #195181
Closes #195182

OAS descriptions and HTTP version for `GET /api/alerting/_health`
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 18, 2024
@jcger
[Response Ops][Alerting] HTTP Version health API (elastic#196690)
b809809 
## Summary

Closes elastic#195181
Closes elastic#195182

OAS descriptions and HTTP version for `GET /api/alerting/_health`

(cherry picked from commit c1ac722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcger jcger

Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Response Ops][Alerting] HTTP Version health API jcger/kibana
3 participants
@cnasikas @elasticmachine @jcger