[Response Ops][Rules] Version Unmute All Rule API #195598
Closed
+55,121
−23,404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcger
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
approved these changes
Oct 9, 2024
| async function unmuteAllWithOCC(context: RulesClientContext, { id }: { id: string }) { | ||
| async function unmuteAllWithOCC(context: RulesClientContext, params: UnmuteAllRuleParams) { | ||
| try { | ||
| unmuteAllRuleParamsSchema.validate(params); |
There was a problem hiding this comment.
Could you please add a unit test for this new change?
|
/ci |
…#195673) This is a re-submission of elastic#191899, which was reverted due to a storybook build problem. This introduces a "Logs Overview" component for use in solution UIs behind a feature flag. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kerry Gallagher <471693+Kerry350@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…lastic#195373) ## Summary It displays correctly the cluster details if they come in the response. To test it you will need a CCS index as the `_clusters` property only comes for these indexes. Other than that it just works out of the bloom as the response is exactly the same as the search api. If we were sending the response correctly in the inspector (it wants: `rawResonse: {....}` and not just the response as we get it), it would have worked without any change from our side. 
… tests (elastic#194922) Closes elastic#186467 ## Summary Removes remaining usages of `supertest` and `superuser` from platform security serverless API tests. Utilizes admin privileges when testing disabled routes, viewer privileges for all other routes. Uses cookie authentication for internal API calls. ### Tests - x-pack/test_serverless/api_integration/test_suites/common/platform_security/authentication.ts - x-pack/test_serverless/api_integration/test_suites/common/platform_security/authorization.ts - Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7089
## Summary This PR fixes the layout of `Color theme updated` toast to match [EUI guidelines on success toasts](https://eui.elastic.co/#/display/toast#success). Fixes: elastic#165979 ## Visuals | Previous | New | |-----------------|-----------------| | |  | ### Checklist Delete any items that are not applicable to this PR. - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
… in observabilityShared navigation (elastic#195557) ## Summary Fixes elastic#195360 and elastic#195560 This PR fixes a bug where the Inventory plugin is improperly registered in the ObservabilityShared navigation, even in spaces that lack the required permissions or for user roles that don't have permissions. As a result, the Inventory link appears in the navigation whenever the space/user has access to any other Observability plugin. ### Space permissions #### Before |Space config|ObservabilityShared navigation| |-|-| ||| ##### After |Space config|ObservabilityShared navigation| |-|-| ||| ||| ### User permissions #### Before |Role config|ObservabilityShared navigation| |-|-| ||| #### After |Role config|ObservabilityShared navigation| |-|-| ||<img width="1266" alt="Screenshot 2024-10-09 at 12 52 48" src="https://github.com/user-attachments/assets/5d21bbef-53ca-4d83-84b7-d471a12a40e3">|
…lastic#195278) ## 📓 Summary Closes elastic#191206 This work fixes issues while accessing the Logs Anomalies and Logs Categories pages due to a lack of user privileges. The privileges were correctly handled until elastic#168234 was merged, which introduced a call to retrieve ml formats information higher in the React hierarchy before the privileges could be asserted for the logged user. This was resulting in the call failing and letting the user stack in loading states or erroneous error pages. These changes lift the license + ML read privileges checks higher in the hierarchy so we can display the right prompts before calling the ml formats API, which will resolve correctly if the user has the right privileges. ### User without valid license <img width="3008" alt="Screenshot 2024-10-07 at 17 01 17" src="https://github.com/user-attachments/assets/bf6478ce-b007-4f15-9538-c7959c497e8a"> ### User with a valid license (or Trial), but no ML privileges <img width="3003" alt="Screenshot 2024-10-07 at 17 03 48" src="https://github.com/user-attachments/assets/c5a82159-b4e8-4f22-9531-23d5e5a9377f"> ### User with a valid license (or Trial) and only Read ML privileges <img width="3003" alt="Screenshot 2024-10-07 at 17 04 21" src="https://github.com/user-attachments/assets/990f4695-e07e-46a2-9214-d0de3628caf7"> ### User with a valid license (or Trial) and All ML privileges, which are the requirements to work with ML Logs features <img width="3000" alt="Screenshot 2024-10-07 at 17 04 52" src="https://github.com/user-attachments/assets/c9b4d832-d3c8-4337-9e17-8a220e7be084"> --------- Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
…on (elastic#195368) ## Summary Adjusted forbidden message for new security route configuration to be consistent with ES. __Closes: https://github.com/elastic/kibana/issues/195365__
## Summary This extracts the Observability AI Assistant into a shared package so Search and Observability can both consume it. A few notes: This still relies on significantly tight coupling with the Obs AI assistant plugin, which we will want to slowly decouple over time. It means that currently to consume this in multiple places, you need to provide a number of plugins for useKibana. Hopefully we can get rid of that and replace them with props eventually and make the interface a little less plugin-dependent. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
jcger
requested review from
a team,
MadameSheema,
patrykkopycinski,
maximpn and
banderror
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/alerting/rule/{id}/_unmute_allin #195181