Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Show Modified badge for fields customized by users #203718

Closed
Tracked by #174168
maximpn opened this issue Dec 11, 2024 · 3 comments · Fixed by #203968
Closed
Tracked by #174168

[Security Solution] Show Modified badge for fields customized by users #203718

maximpn opened this issue Dec 11, 2024 · 3 comments · Fixed by #203968
Assignees
@maximpn
Labels
8.18 candidate enhancement New value added to drive a business result Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@maximpn
Copy link
Contributor

maximpn commented Dec 11, 2024 •
edited
Loading

Epic: #174168
Relates to: #171520
Design: Figma (internal)

Summary

Users should be able to easily spot prebuilt rule fields they made customizaition to. Such fields should have Modified badge added next to the field name as show in the design.

Design screenshots

Image

Image

Image
@maximpn maximpn added 8.18 candidate enhancement New value added to drive a business result Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team labels Dec 11, 2024
@maximpn maximpn self-assigned this Dec 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

This was referenced Dec 11, 2024
Merged
Open
@banderror banderror removed the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Dec 11, 2024
@maximpn maximpn mentioned this issue Dec 12, 2024
Merged
@maximpn maximpn linked a pull request Dec 12, 2024 that will close this issue
[Security Solution] Display Modified badge for customized fields in Rule Upgrade flyout #203968
Merged
maximpn added a commit that referenced this issue Dec 13, 2024
@maximpn
[Security Solution] Display Modified badge for customized fields in R…
87079ff 
…ule Upgrade flyout (#203968)

**Resolves:** #203718

## Summary

This PR adds `Modified` badge to customized fields in rules upgrade flyout.

## Details

`_review` API endpoint contains fields diff providing enough information on what field values were involved in the comparison. In particular `diff_outcome` is used to determine if a field was customized i.e. the rule was edited and field value has a different value than a stock value. `Modified` badge is show for fields `CustomizedValueCanUpdate`, `CustomizedValueSameUpdate` and `CustomizedValueNoUpdate`.

## Screenshot

![image](https://github.com/user-attachments/assets/8f773f45-7ab5-4883-9ef7-fee8f3bde768)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 13, 2024
@maximpn
[Security Solution] Display Modified badge for customized fields in R…
c8e8885 
…ule Upgrade flyout (elastic#203968)

**Resolves:** elastic#203718

## Summary

This PR adds `Modified` badge to customized fields in rules upgrade flyout.

## Details

`_review` API endpoint contains fields diff providing enough information on what field values were involved in the comparison. In particular `diff_outcome` is used to determine if a field was customized i.e. the rule was edited and field value has a different value than a stock value. `Modified` badge is show for fields `CustomizedValueCanUpdate`, `CustomizedValueSameUpdate` and `CustomizedValueNoUpdate`.

## Screenshot

![image](https://github.com/user-attachments/assets/8f773f45-7ab5-4883-9ef7-fee8f3bde768)

(cherry picked from commit 87079ff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximpn maximpn

Labels
8.18 candidate enhancement New value added to drive a business result Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
3 participants
@maximpn @banderror @elasticmachine