[Security Solution] Display Modified badge for customized fields in Rule Upgrade flyout #203968
+50
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpn
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
nikitaindik
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Thanks for the PR, @maximpn. I've reviewed the code and tested it locally.
I have a couple of concerns that are related to the product side of the feature.
- The term "Modified" is too generic; it can mean both "Current differs from Base" and "you've made changes in the Final Update section." But right now I can't think of a better term to avoid this confusion.
- IMO, we should not use the term "stock value" since it might be unclear what it refers to. Maybe "original value", although it's also not perfect. This seems like a decision for the Kseniia / docs folks regarding precise wording.
maximpn
force-pushed
the
add-field-modified-badge
branch
from
b087f2a to
3acaec6
Compare
maximpn
force-pushed
the
add-field-modified-badge
branch
from
3acaec6 to
1b6cf09
Compare
|
@nikitaindik thanks for your review 🙏
Doc folks may have some suggestion here. I tweaked the texts a bit for better clarity. Let's discuss both items above at our product sync meeting. |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12315028947 |
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @maximpn |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 13, 2024
…ule Upgrade flyout (elastic#203968) **Resolves:** elastic#203718 ## Summary This PR adds `Modified` badge to customized fields in rules upgrade flyout. ## Details `_review` API endpoint contains fields diff providing enough information on what field values were involved in the comparison. In particular `diff_outcome` is used to determine if a field was customized i.e. the rule was edited and field value has a different value than a stock value. `Modified` badge is show for fields `CustomizedValueCanUpdate`, `CustomizedValueSameUpdate` and `CustomizedValueNoUpdate`. ## Screenshot  (cherry picked from commit 87079ff)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 13, 2024
…s in Rule Upgrade flyout (#203968) (#204195) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Display Modified badge for customized fields in Rule Upgrade flyout (#203968)](#203968) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2024-12-13T11:43:45Z","message":"[Security Solution] Display Modified badge for customized fields in Rule Upgrade flyout (#203968)\n\n**Resolves:** https://github.com/elastic/kibana/issues/203718\r\n\r\n## Summary\r\n\r\nThis PR adds `Modified` badge to customized fields in rules upgrade flyout.\r\n\r\n## Details\r\n\r\n`_review` API endpoint contains fields diff providing enough information on what field values were involved in the comparison. In particular `diff_outcome` is used to determine if a field was customized i.e. the rule was edited and field value has a different value than a stock value. `Modified` badge is show for fields `CustomizedValueCanUpdate`, `CustomizedValueSameUpdate` and `CustomizedValueNoUpdate`.\r\n\r\n## Screenshot\r\n\r\n","sha":"87079ff226b616d3b11370f7307f5c7448001b28","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","impact:medium","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0"],"title":"[Security Solution] Display Modified badge for customized fields in Rule Upgrade flyout","number":203968,"url":"https://github.com/elastic/kibana/pull/203968","mergeCommit":{"message":"[Security Solution] Display Modified badge for customized fields in Rule Upgrade flyout (#203968)\n\n**Resolves:** https://github.com/elastic/kibana/issues/203718\r\n\r\n## Summary\r\n\r\nThis PR adds `Modified` badge to customized fields in rules upgrade flyout.\r\n\r\n## Details\r\n\r\n`_review` API endpoint contains fields diff providing enough information on what field values were involved in the comparison. In particular `diff_outcome` is used to determine if a field was customized i.e. the rule was edited and field value has a different value than a stock value. `Modified` badge is show for fields `CustomizedValueCanUpdate`, `CustomizedValueSameUpdate` and `CustomizedValueNoUpdate`.\r\n\r\n## Screenshot\r\n\r\n","sha":"87079ff226b616d3b11370f7307f5c7448001b28"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203968","number":203968,"mergeCommit":{"message":"[Security Solution] Display Modified badge for customized fields in Rule Upgrade flyout (#203968)\n\n**Resolves:** https://github.com/elastic/kibana/issues/203718\r\n\r\n## Summary\r\n\r\nThis PR adds `Modified` badge to customized fields in rules upgrade flyout.\r\n\r\n## Details\r\n\r\n`_review` API endpoint contains fields diff providing enough information on what field values were involved in the comparison. In particular `diff_outcome` is used to determine if a field was customized i.e. the rule was edited and field value has a different value than a stock value. `Modified` badge is show for fields `CustomizedValueCanUpdate`, `CustomizedValueSameUpdate` and `CustomizedValueNoUpdate`.\r\n\r\n## Screenshot\r\n\r\n","sha":"87079ff226b616d3b11370f7307f5c7448001b28"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #203718
Summary
This PR adds
Modifiedbadge to customized fields in rules upgrade flyout.Details
_reviewAPI endpoint contains fields diff providing enough information on what field values were involved in the comparison. In particulardiff_outcomeis used to determine if a field was customized i.e. the rule was edited and field value has a different value than a stock value.Modifiedbadge is show for fieldsCustomizedValueCanUpdate,CustomizedValueSameUpdateandCustomizedValueNoUpdate.Screenshot