Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] React-Intl v3 soon out of beta #38642

Closed
Bamieh opened this issue Jun 11, 2019 · 10 comments · Fixed by #179506
Closed

[i18n] React-Intl v3 soon out of beta #38642

Bamieh opened this issue Jun 11, 2019 · 10 comments · Fixed by #179506
Assignees
Labels
loe:large Large Level of Effort Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@Bamieh
Copy link
Member

Bamieh commented Jun 11, 2019

We should consider upgrading react-Intl to v3 when it goes stable (currently in beta-7).

Main features:

Currently we wrap the react-Intl provider to support pseudo-locale (en-xa). With the new context we might need to update our I18nProvider code.

cc @azasypkin

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services

@legrego
Copy link
Member

legrego commented Dec 17, 2019

++ I'm working on cleaning up React warnings in our plugin code, and one that I can't remove is being thrown by our current version of react-intl's FormattedRelative:

console.warn ../node_modules/react-dom/cjs/react-dom.development.js:12357
      Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.
      
      * Move data fetching code or side effects to componentDidUpdate.
      * If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at:
 https://fb.me/react-derived-state
      * Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will wo
rk. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.
      
      Please update the following components: FormattedRelative

@jfsiii
Copy link
Contributor

jfsiii commented Feb 21, 2020

Can someone give a quick status on this? react-intl is now on v3.12 in the 9 months since the OP.

@Bamieh
Copy link
Member Author

Bamieh commented Feb 23, 2020

@jfsiii I will try to prioratize it for 7.7. We dont have resources to follow up on most non-urgent i18n issues so this is still on hold.

@jportner
Copy link
Contributor

jportner commented Oct 7, 2020

Just wanted to ping on this and see if there's been any movement on it 🙂

@Bamieh
Copy link
Member Author

Bamieh commented Oct 11, 2020

@jportner I've moved react-intl inside our i18n package and removed it from kibana src and xpack. This will ease the upgrade.

The upgrade will require some coordinated effert with eui since they also use a react-intl provider for their EuiContext. There are breaking changes in some components like RelativeDateFormatter and some removed components that we expose directly to our users.

This means that any plugin (external or internal) will break after this change. We might need to provide these components from our side for backwards compatiblity to not break any external plugins.

This issue will remain on hold until I get an OK to prioratize it and work on it. cc @bmcconaghy

@bmcconaghy
Copy link
Contributor

@Bamieh I think it makes sense to try to get this done. Re: backwards compatibility, I don't think we need to worry about that as the contract that is being changed is provided by an external dependency. I would definitely prefer that we not try to carry deprecated components forward if we can get away with it.

@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 4, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:large Large Level of Effort loe:x-large Extra Large Level of Effort and removed loe:small Small Level of Effort loe:large Large Level of Effort loe:x-large Extra Large Level of Effort labels Feb 8, 2022
@Bamieh Bamieh removed the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Mar 10, 2024
@legrego
Copy link
Member

legrego commented Mar 14, 2024

Any updates to share on this? react-intl is now up to version 6.6.2

@Bamieh
Copy link
Member Author

Bamieh commented Mar 19, 2024

@legrego the i18n project has been on maintenance mode for a while. I've created an epic for this with the reasearch and full tasks breadown, so we should be ready to get started on this once I get the OK to get this started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loe:large Large Level of Effort Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants